Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: Use events to know if file upload is supported

Download Browse

How to test: No functional change for image drag/drop in the artifact modal: - when there is at least one File field in the tracker, image drag/drop is enabled and functions as before. - when there is no File field, it is not supported (the helper sentence is not shown below the CKEditor). part of request #31111: Remove global states in the artifact modal Change-Id: Ib3f927c73b53477aa1f8ee21a4eb5abd86a64cb2

+256 −128
Joris MASSON (jmasson) 2023-03-01 16:34
Joris MASSON (jmasson) 2023-03-03 15:32
9290dff366cdfc46a1fffc5832441065c5450b0e
ab04bd28167c158ef00df3dd38bda66c05b3af31
git #tuleap/stable/9290dff366cdfc46a1fffc5832441065c5450b0e

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/comments/FollowupEditor.test.ts +7 −1 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/comments/FollowupEditor.ts +1 −0 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/comments/ModalCommentsSection.ts +4 −0 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/file-field/file-field-detector.test.ts +1 −44 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/file-field/file-field-detector.ts +0 −5 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/text-field/TextField.test.ts +7 −1 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/text-field/TextField.ts +1 −0 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/common/RichTextEditor.test.ts +12 −12 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/common/RichTextEditor.ts +20 −14 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/common/text-and-format.test.ts +3 −0 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/common/text-and-format.ts +3 −0 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/domain/DomainEvent.ts +2 −0 Go to diff View file
A plugins/tracker/scripts/lib/artifact-modal/src/domain/common/FormattedTextController.test.ts +52 −0 Go to diff View file
A plugins/tracker/scripts/lib/artifact-modal/src/domain/common/FormattedTextController.ts +36 −0 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/domain/fields/file-field/FileFieldController.test.ts +25 −1 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/domain/fields/file-field/FileFieldController.ts +11 −0 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/domain/fields/file-field/FileFieldType.ts +8 −8 Go to diff View file
A plugins/tracker/scripts/lib/artifact-modal/src/domain/fields/file-field/FileUploadSetup.ts +27 −0 Go to diff View file
A plugins/tracker/scripts/lib/artifact-modal/src/domain/fields/file-field/WillGetFileUploadSetup.ts +30 −0 Go to diff View file
D plugins/tracker/scripts/lib/artifact-modal/src/model/FirstFileFieldStore.ts +0 −35 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/tuleap-artifact-modal-controller.js +4 −0 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/tuleap-artifact-modal-service.js +0 −7 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/tuleap-artifact-modal.tpl.html +2 −0 Go to diff View file