stable
Clone or download
When Alice invites `bob@example.com` in a project and there is already an existing user Bob with this email then we add Bob in the project and we don't need to send him an invitation (He will receive a welcome-to project notification). If the addition of the user as project member fails, then the reason is displayed in the feedback modal. Feedbacks that are added in ManageProjectInvitationsController are here to cover race conditions: admin resend an invitation and at the same time the invitation is completed and user added to project. The chances to get those feedbacks are slim, maybe the default "Invitation has been resent" would be good enough… 🤔 Part of story #30021: Invite buddies to my Tuleap project Change-Id: Ibe327dbcfd43a384ecd8f25b17a4337be0aa09d1
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | site-content/fr_FR/LC_MESSAGES/tuleap-core.po | +20 | −4 | Go to diff View file |
| M | site-content/pt_BR/LC_MESSAGES/tuleap-core.po | +16 | −2 | Go to diff View file |
| M | src/common/InviteBuddy/InvitationSender.php | +36 | −4 | Go to diff View file |
| M | src/common/InviteBuddy/REST/v1/InvitationPOSTResultRepresentation.php | +23 | −3 | Go to diff View file |
| M | src/common/InviteBuddy/REST/v1/InvitationsResource.php | +2 | −0 | Go to diff View file |
| M | src/common/InviteBuddy/SentInvitationResult.php | +7 | −1 | Go to diff View file |
| M | src/common/Project/Admin/Invitations/ManageProjectInvitationsController.php | +34 | −8 | Go to diff View file |
| M | src/common/Request/RouteCollector.php | +1 | −0 | Go to diff View file |
| M | src/scripts/main/src/invite-buddies/feedback-display.test.ts | +93 | −1 | Go to diff View file |
| M | src/scripts/main/src/invite-buddies/feedback-display.ts | +104 | −29 | Go to diff View file |
| M | src/scripts/main/src/invite-buddies/po/fr_FR.po | +54 | −0 | Go to diff View file |
| M | tests/unit/common/InviteBuddy/InvitationSenderTest.php | +116 | −13 | Go to diff View file |
| M | tests/unit/common/Project/Admin/Invitations/ManageProjectInvitationsControllerTest.php | +3 | −3 | Go to diff View file |