stable

Clone or download

Read-only

Refactoring of TrackerCreatorXmlDisplayer

part of story #14291 Beautiful tracker creation This change aims to increase readability and maintenance of xml error display for tracker creation UI. The string render have been extracted into a mustache file. It also correct a bug: - when you file has more than a single error, before only the first error was displayed - with this patch, every single line in error will have its associated error displayed Please test that display is correctly rendered in legacy and new tracker creation UI Change-Id: Ic71e7d31f426ba531743e082fef237920b45187f

Modified Files

Name
M plugins/tracker/include/Tracker/Creation/TrackerCreatorXmlErrorDisplayer.php +20 −90 Go to diff View file
A plugins/tracker/include/Tracker/Creation/TrackerCreatorXmlErrorPresenter.php +37 −0 Go to diff View file
A plugins/tracker/include/Tracker/Creation/TrackerCreatorXmlErrorPresenterBuilder.php +91 −0 Go to diff View file
M plugins/tracker/include/trackerPlugin.php +2 −1 Go to diff View file
D plugins/tracker/phpunit/Tracker/Creation/TrackerCreatorXmlErrorDisplayerTest.php +0 −131 Go to diff View file
A plugins/tracker/phpunit/Tracker/Creation/TrackerCreatorXmlErrorPresenterBuilderTest.php +128 −0 Go to diff View file
M plugins/tracker/site-content/fr_FR/LC_MESSAGES/tuleap-tracker.po +3 −0 Go to diff View file
A plugins/tracker/templates/tracker-creation/xml-invalid-tracker.mustache +20 −0 Go to diff View file
M plugins/tracker/themes/BurningParrot/css/_tracker.scss +1 −0 Go to diff View file
A plugins/tracker/themes/default/css/includes/_xml-validation.scss +42 −0 Go to diff View file
M plugins/tracker/themes/default/css/style.scss +1 −0 Go to diff View file