stable

Clone or download

Read-only

Harden identifier typing

part of story #24969 [modal] add and remove links without types No functional change expected in the "Parent feedback" and the new Artifact link field Notes: This lets us stop primitive obsession with artifact ids. It even simplifies some of the code because we can deduce from the identifier if the modal is in creation or edition mode. Change-Id: I61b3353ed0f5140b5bdf41bb865d6e2f72776186

Modified Files

Name
M .eslintrc.js +18 −3 Go to diff View file
M plugins/agiledashboard/scripts/planning-v2/src/app/planner-view/planner-view-component.js +3 −1 Go to diff View file
A plugins/tracker/scripts/lib/artifact-modal/src/adapters/Caller/CurrentArtifactIdentifierProxy.test.ts +36 −0 Go to diff View file
A plugins/tracker/scripts/lib/artifact-modal/src/adapters/Caller/CurrentArtifactIdentifierProxy.ts +32 −0 Go to diff View file
A plugins/tracker/scripts/lib/artifact-modal/src/adapters/Caller/ParentArtifactIdentifierProxy.test.ts +40 −0 Go to diff View file
A plugins/tracker/scripts/lib/artifact-modal/src/adapters/Caller/ParentArtifactIdentifierProxy.ts +32 −0 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/REST/APILinkedArtifact.ts +1 −1 Go to diff View file
A plugins/tracker/scripts/lib/artifact-modal/src/adapters/REST/LinkedArtifactIdentifierProxy.test.ts +33 −0 Go to diff View file
R plugins/tracker/scripts/lib/artifact-modal/tests/stubs/VerifyIsInCreationModeStub.ts Go to diff View file
A plugins/tracker/scripts/lib/artifact-modal/src/adapters/REST/LinkedArtifactProxy.test.ts +64 −0 Go to diff View file
R plugins/tracker/scripts/lib/artifact-modal/src/domain/parent/ParentRetriever.ts Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/REST/TuleapAPIClient.test.ts +14 −8 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/REST/TuleapAPIClient.ts +17 −13 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/feedback/ModalFeedbackController.test.ts +10 −7 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/feedback/ModalFeedbackController.ts +6 −5 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field-v2/LinkField.test.ts +3 −0 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field-v2/LinkFieldController.test.ts +7 −6 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field-v2/LinkFieldController.ts +4 −5 Go to diff View file
R plugins/tracker/scripts/lib/artifact-modal/src/domain/parent/RetrieveParent.ts Go to diff View file
A plugins/tracker/scripts/lib/artifact-modal/src/domain/Identifier.ts +40 −0 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/domain/RetrieveArtifact.ts +5 −1 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/domain/fields/link-field-v2/LinkedArtifact.ts +6 −0 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/domain/fields/link-field-v2/LinksRetriever.test.ts +2 −1 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/domain/fields/link-field-v2/LinksRetriever.ts +9 −3 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/domain/fields/link-field-v2/RetrieveAllLinkedArtifacts.ts +4 −1 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/domain/fields/link-field-v2/RetrieveLinkTypes.ts +2 −1 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/domain/fields/link-field-v2/RetrieveLinkedArtifactsByType.ts +2 −1 Go to diff View file
R plugins/tracker/scripts/lib/artifact-modal/src/domain/VerifyIsInCreationMode.ts Go to diff View file
D plugins/tracker/scripts/lib/artifact-modal/src/domain/parent/ParentRetriever.test.ts +0 −56 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/tuleap-artifact-modal-controller.js +5 −7 Go to diff View file
R plugins/tracker/scripts/lib/artifact-modal/src/adapters/Memory/CreationModeVerifier.ts Go to diff View file
R plugins/tracker/scripts/lib/artifact-modal/tests/stubs/RetrieveParentStub.ts Go to diff View file
A plugins/tracker/scripts/lib/artifact-modal/tests/stubs/ParentArtifactIdentifierStub.ts +24 −0 Go to diff View file