stable
Clone or download
Read-only
part of story #31537 Add tags and make them updatable The current pull-request id is retrieved from the route params as a string and stored as is. We are forced to parse it as an int all the time, and there are no reasons to keep it a string. This contribution makes it a number and removes all the unecessary casts here and there. -- No functional change expected Change-Id: Ica7de1b6d9fea3105c24dfbabb786015600f6713
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/pullrequest/scripts/pullrequest-overview/src/api/tuleap-rest-querier.test.ts | +2 | −2 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/api/tuleap-rest-querier.ts | +4 | −4 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/components/Actions/abandon/PullRequestAbandonButton.test.ts | +1 | −1 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/components/Actions/abandon/PullRequestAbandonButton.vue | +1 | −1 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/components/Actions/abandon/PullRequestAbandonedState.test.ts | +1 | −1 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/components/Actions/abandon/PullRequestAbandonedState.vue | +1 | −1 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/components/Actions/merge/PullRequestMergeButton.test.ts | +1 | −1 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/components/Actions/merge/PullRequestMergeButton.vue | +1 | −1 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/components/Errors/PullRequestErrorModal.test.ts | +14 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/components/Errors/PullRequestErrorModal.vue | +6 | −2 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/components/Labels/PullRequestLabels.test.ts | +1 | −1 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/components/Labels/PullRequestLabels.vue | +1 | −1 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/components/OverviewPane.test.ts | +2 | −2 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/components/OverviewPane.vue | +2 | −1 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/components/OverviewTabs.test.ts | +2 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/components/OverviewTabs.vue | +1 | −1 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/components/Reviewers/PullRequestManageReviewersModal.test.ts | +1 | −1 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/components/Reviewers/PullRequestManageReviewersModal.vue | +1 | −1 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/components/Reviewers/PullRequestReviewerList.test.ts | +1 | −3 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/components/Reviewers/PullRequestReviewerList.vue | +1 | −1 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/components/Threads/CommentPresenterBuilder.test.ts | +1 | −1 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/components/Threads/CommentPresenterBuilder.ts | +2 | −2 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/components/Threads/OverviewNewCommentForm.test.ts | +3 | −1 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/components/Threads/OverviewNewCommentForm.vue | +2 | −2 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/components/Threads/OverviewThreads.test.ts | +3 | −1 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/components/Threads/OverviewThreads.vue | +2 | −2 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/constants.ts | +1 | −1 | Go to diff View file |
| A | plugins/pullrequest/scripts/pullrequest-overview/src/helpers/pull-request-id-extractor.test.ts | +39 | −0 | Go to diff View file |
| A | plugins/pullrequest/scripts/pullrequest-overview/src/helpers/pull-request-id-extractor.ts | +33 | −0 | Go to diff View file |