stable

Clone or download

Read-only

Split CheckProgramIncrement interface

part of request #22231 Decrease adapter responsibility No functional change expected. You can check for non-regression with REST tests and cypress end-to-end tests. Splitting lets us reuse the VerifyIsVisibleArtifact interface, it is consistent with IterationIdentifier. It was also the opportunity to remove a dependency on \PFUser in favor of UserIdentifier. Change-Id: I39d17fac7c6d14b6cf16798f5589056ed58b6661

Modified Files

Name
M plugins/program_management/include/Adapter/Program/Backlog/ProgramIncrement/ProgramIncrementsDAO.php +10 −1 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/ProgramIncrement/ProgramIncrementsRetriever.php +11 −6 Go to diff View file
M plugins/program_management/include/Adapter/Program/Feature/Content/FeatureContentRetriever.php +18 −9 Go to diff View file
D plugins/program_management/include/Adapter/Program/Feature/Content/ProgramIncrementChecker.php +0 −57 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/AsynchronousCreation/IterationCreation.php +8 −10 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/AsynchronousCreation/ProgramIncrementUpdateEventHandler.php +12 −17 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/Content/ContentModifier.php +17 −9 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/Content/ModifyContent.php +5 −3 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/ProgramIncrementIdentifier.php +14 −9 Go to diff View file
R plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/CheckProgramIncrement.php Go to diff View file
M plugins/program_management/include/REST/v1/ProgramIncrementResource.php +13 −7 Go to diff View file
M plugins/program_management/include/REST/v1/ProjectResource.php +4 −3 Go to diff View file
M plugins/program_management/include/program_managementPlugin.php +3 −6 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/Content/FeatureAdditionProcessorTest.php +7 −39 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/ProgramIncrementsRetrieverTest.php +4 −2 Go to diff View file
D plugins/program_management/tests/unit/Adapter/Program/Feature/Content/ProgramIncrementCheckerTest.php +0 −110 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Feature/Content/ProgramIncrementContentRetrieverTest.php +5 −3 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Feature/UserStoriesInMirroredProgramIncrementsPlannerTest.php +0 −6 Go to diff View file
A plugins/program_management/tests/unit/Builder/ProgramIncrementIdentifierBuilder.php +43 −0 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/AsynchronousCreation/IterationCreationTest.php +15 −26 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/AsynchronousCreation/ProgramIncrementUpdateEventHandlerTest.php +14 −18 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/Iteration/IterationIdentifierTest.php +10 −15 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/Iteration/JustLinkedIterationCollectionTest.php +5 −10 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/ProgramIncrement/Content/ContentModifierTest.php +61 −154 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/ProgramIncrement/Content/FeatureAdditionTest.php +5 −11 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/ProgramIncrement/ProgramIncrementIdentifierTest.php +37 −12 Go to diff View file
R plugins/program_management/tests/unit/Stub/CheckProgramIncrementStub.php Go to diff View file