stable

Clone or download

Read-only

Add a proxy arround PFUser object in UserIdentifier

part of request #22231 Decrease adapter responsibility UserIdentifier is now built around a Proxy of PFUser, PFUser is no more leaked inside it. This is "a small" changes, there is still many references to PFUser Once I'll end, we should no longer have PFUser outside Proxy A stub for proxy have been introduce into test (`PFUserAttributes`) and instead of depending of UserTestBuilder->aUser->with->with we'll be able to directly get a generic user based on static mechanisms Change-Id: Ib76434119f767ac336bd74985f4db1b9f3473e6c

Modified Files

Name
M plugins/program_management/include/Adapter/Events/ArtifactUpdatedProxy.php +4 −2 Go to diff View file
M plugins/program_management/include/Adapter/Program/Admin/Configuration/ConfigurationChecker.php +3 −2 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/AsynchronousCreation/CreateProgramIncrementsTask.php +3 −2 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/AsynchronousCreation/IterationCreationsRunner.php +1 −1 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/AsynchronousCreation/PendingIterationCreationDAO.php +1 −1 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/ProgramIncrement/Content/FeatureAdditionProcessor.php +1 −2 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/ProgramIncrement/Content/FeatureRemovalProcessor.php +1 −2 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/TopBacklog/ArtifactTopBacklogActionBuilder.php +2 −2 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/TopBacklog/MassChangeTopBacklogActionBuilder.php +2 −2 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/TopBacklog/MassChangeTopBacklogActionProcessor.php +7 −12 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/TopBacklog/ProcessTopBacklogChange.php +4 −3 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/TopBacklog/Workflow/AddToTopBacklogPostAction.php +4 −3 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/TopBacklog/Workflow/AddToTopBacklogPostActionFactory.php +9 −17 Go to diff View file
M plugins/program_management/include/Adapter/Program/Feature/Content/FeatureContentRetriever.php +8 −18 Go to diff View file
M plugins/program_management/include/Adapter/Program/Feature/FeatureElementsRetriever.php +6 −15 Go to diff View file
M plugins/program_management/include/Adapter/Program/Feature/FeatureRepresentationBuilder.php +2 −2 Go to diff View file
M plugins/program_management/include/Adapter/Workspace/UserManagerAdapter.php +1 −1 Go to diff View file
A plugins/program_management/include/Adapter/Workspace/UserProxy.php +55 −0 Go to diff View file
M plugins/program_management/include/DisplayAdminProgramManagementController.php +4 −3 Go to diff View file
M plugins/program_management/include/DisplayProgramBacklogController.php +5 −4 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/AsynchronousCreation/IterationCreation.php +2 −1 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/AsynchronousCreation/IterationCreationEventHandler.php +1 −1 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/CreationCheck/CanSubmitNewArtifactHandler.php +3 −2 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/Content/ContentModifier.php +5 −4 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/Content/FeatureRemoval.php +3 −10 Go to diff View file
M plugins/program_management/include/Domain/Program/ProgramSearcher.php +4 −10 Go to diff View file
M plugins/program_management/include/Domain/Program/ToBeCreatedProgram.php +3 −3 Go to diff View file
M plugins/program_management/include/Domain/Team/Creation/TeamCreator.php +6 −13 Go to diff View file
M plugins/program_management/include/Domain/UserCanPrioritize.php +9 −4 Go to diff View file
M plugins/program_management/include/Domain/Workspace/UserIdentifier.php +2 −24 Go to diff View file
M plugins/program_management/include/REST/v1/ProjectResource.php +7 −3 Go to diff View file
M plugins/program_management/tests/rest/v1/Helper/ProgramDataBuilder.php +4 −1 Go to diff View file
M plugins/program_management/tests/unit/Adapter/ArtifactVisibleVerifierTest.php +2 −1 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Events/ArtifactUpdatedProxyTest.php +1 −1 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/AsynchronousCreation/IterationCreationsRunnerTest.php +2 −2 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/CreationCheck/RequiredFieldCheckerTest.php +3 −3 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/CreationCheck/SemanticCheckerTest.php +8 −8 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/CreationCheck/StatusSemanticCheckerTest.php +2 −2 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/CreationCheck/WorkflowCheckerTest.php +6 −6 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/Content/FeatureAdditionProcessorTest.php +3 −3 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/Content/FeatureRemovalProcessorTest.php +2 −2 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/ProgramIncrementsRetrieverTest.php +2 −2 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/Rank/FeaturesRankOrdererTest.php +2 −3 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/TopBacklog/ProcessTopBacklogChangeTest.php +8 −8 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Feature/FeatureRepresentationBuilderTest.php +4 −4 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Feature/Links/UserStoryLinkedToFeatureCheckerTest.php +2 −1 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Feature/UserStoriesInMirroredProgramIncrementsPlannerTest.php +2 −1 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Feature/VerifyIsVisibleFeatureAdapterTest.php +2 −1 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/IterationTracker/VisibleIterationTrackerRetrieverTest.php +2 −2 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Plan/PrioritizeFeaturesPermissionVerifierTest.php +2 −1 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Plan/ProgramAdapterTest.php +6 −6 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/ProgramIncrementTracker/VisibleProgramIncrementTrackerRetrieverTest.php +2 −2 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Team/TeamAdapterTest.php +9 −6 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Workspace/UserPermissionsProxyTest.php +1 −2 Go to diff View file
A plugins/program_management/tests/unit/Adapter/Workspace/UserProxyTest.php +41 −0 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Admin/Team/TeamsPresenterBuilderTest.php +2 −5 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Admin/TimeboxTrackerConfiguration/PotentialTimeboxTrackerConfigurationPresenterCollectionTest.php +2 −2 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/AsynchronousCreation/IterationCreationTest.php +5 −4 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/AsynchronousCreation/IterationReplicationSchedulerTest.php +2 −1 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/AsynchronousCreation/ProgramIncrementsCreatorTest.php +5 −2 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/CreationCheck/IterationCreatorCheckerTest.php +2 −2 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/CreationCheck/ProgramIncrementCreatorCheckerTest.php +2 −2 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/CreationCheck/TimeboxCreatorCheckerTest.php +3 −3 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/Feature/FeatureIdentifierTest.php +3 −4 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/Iteration/IterationIdentifierTest.php +2 −2 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/Iteration/JustLinkedIterationCollectionTest.php +2 −2 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/IterationTracker/IterationLabelsTest.php +2 −2 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/ProgramIncrement/Content/FeatureAdditionTest.php +3 −3 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/ProgramIncrement/Content/FeatureRemovalTest.php +3 −4 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/ProgramIncrement/ProgramIncrementBuilderTest.php +2 −1 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/ProgramIncrement/Source/Changeset/Values/SynchronizedFieldCollectionBuilderTest.php +3 −3 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/ProgramIncrement/Team/TeamProjectsCollectionTest.php +2 −2 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/ProgramIncrementTracker/ProgramIncrementTrackerConfigurationTest.php +2 −2 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/Source/SourceTrackerCollectionTest.php +2 −2 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/TrackerCollectionTest.php +16 −9 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/ProgramIdentifierTest.php +2 −3 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/ProgramSearcherTest.php +9 −11 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Team/TeamCreatorTest.php +3 −2 Go to diff View file
M plugins/program_management/tests/unit/Domain/ProgramTrackerTest.php +4 −4 Go to diff View file
D plugins/program_management/tests/unit/Domain/Workspace/UserIdentifierTest.php +0 −65 Go to diff View file
A plugins/program_management/tests/unit/Stub/UserIdentifierStub.php +51 −0 Go to diff View file
A plugins/program_management/tests/unit/UserCanPrioritizeTest.php +68 −0 Go to diff View file