Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

PHPUnit unit test suite can fail when played in a random order

Download Browse

Due to a test introduced in 8efe3256013155d2bd2e9c6429aeeeeaa114e8d3, the test suite can fail. A PHP bug exists with simplexml_load_file() when the ability to load external entities has been disabled [0]. Some tests enable/disable the feature resulting in a failure depending on when PsalmCommandLauncherWithIgnoreDirectoryTest is played. Issue can be reproduced by executing the test suite with the random seed 1552981703. Part of request #13038: Introduce static analysis of the PHP codebase with vimeo/psalm [0] https://bugs.php.net/bug.php?id=62577 Change-Id: I310c05eedae00ab9420a657cc320d2f12e770a33

+10 −5
Thomas Gerbet (tgerbet) 2019-03-19 09:04
Thomas Gerbet (tgerbet) 2019-03-19 09:12
a37a9ab70ea41f3c856f911667bf5840744a4cf9
1b4bbdc2f329a1d756545e2a191d3f4d7740f79d
git #tuleap/stable/a37a9ab70ea41f3c856f911667bf5840744a4cf9

Modified Files

Side by side diff
Inline diff
Name
M tests/lib/Psalm/PsalmCommandLauncherWithIgnoreDirectory.php +8 −3 Go to diff View file
M tests/phpunit/tests/Psalm/PsalmCommandLauncherWithIgnoreDirectoryTest.php +2 −2 Go to diff View file