Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Refactoring rules validator first part

Download Browse

part of request #13691 This patch split list validator on new files and change some tests to test the new file with phpunit and adapt tracker_rulesManager's simpletests. The entire refactoring has for objectiv to have better, more maintainable and more testable code for futures patchs, especially for request #13634 wich will come after. Next part will split ValidateListRules function is little parts and with more modern Php. Change-Id: Ib5ed04bd4765f2ad15c242707991e8d01bd5a49e

+655 −582
Lorentz Romain (lorentzr) 2019-07-29 12:03
Lorentz Romain (lorentzr) 2019-08-05 15:23
a4c3d5c9c815c5cf04ea8ac17f74398f06e8bd63
fbf6f8674f94e7ee666c229a53b4e44ac43ff3b7
git #tuleap/stable/a4c3d5c9c815c5cf04ea8ac17f74398f06e8bd63

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElementFactory.class.php +12 −0 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field.class.php +9 −2 Go to diff View file
A plugins/tracker/include/Tracker/Rule/TrackerRulesListValidator.php +183 −0 Go to diff View file
M plugins/tracker/include/Tracker/Rule/Tracker_RulesManager.class.php +15 −150 Go to diff View file
M plugins/tracker/include/Workflow/WorkflowFactory.class.php +6 −1 Go to diff View file
A plugins/tracker/phpunit/Tracker/Rules/TrackerRulesListValidatorTest.php +393 −0 Go to diff View file
M plugins/tracker/tests/Tracker_RulesManagerTest.php +37 −429 Go to diff View file