Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Extract sending of a comment to a dedicated object

Download Browse

This is a refactoring to be able later to send an email when the credentials are expired. The new object does not do much, but will catch credentials error in a dedicated changeset. This is not done in postUrl because we don't want to send an email when the user fails to create a repository. Only posting comment is concerned. No functional changes. Part of story #17182: reference tuleap artifacts in gitlab merge requests Change-Id: I7c0bd13e3b43703aa5f5bf7c4c747523834a9e31

+71 −16
Nicolas Terray (nterray) 2021-01-22 09:17
Nicolas Terray (nterray) 2021-01-22 09:17
a4cfb62683620c42d7efc4c3a59af528d1747d16
373d2731e0ded4751c76d5afa9bad702d48930ff
git #tuleap/stable/a4cfb62683620c42d7efc4c3a59af528d1747d16

Modified Files

Side by side diff
Inline diff
Name
A plugins/gitlab/include/Repository/Webhook/Bot/CommentSender.php +52 −0 Go to diff View file
M plugins/gitlab/include/Repository/Webhook/PostMergeRequest/PostMergeRequestBotCommenter.php +6 −6 Go to diff View file
M plugins/gitlab/include/Repository/Webhook/PostPush/PostPushCommitBotCommenter.php +6 −6 Go to diff View file
M plugins/gitlab/include/gitlabPlugin.php +3 −2 Go to diff View file
M plugins/gitlab/tests/unit/Repository/Webhook/PostMergeRequest/PostMergeRequestBotCommenterTest.php +2 −1 Go to diff View file
M plugins/gitlab/tests/unit/Repository/Webhook/PostPush/PostPushCommitBotCommenterTest.php +2 −1 Go to diff View file