Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Keep the history of changes made on the reviewers of a pull-request

Download Browse

This change is technical, nothing functional changes are visible for now. The history of the changes made on the reviewers of a pull-request is now kept. This will be useful to send the notifications (easy replay of the event in case of failure) and to add this information in the timeline of the pull request. You can check that the changes are kept by taking a look at the content of plugin_pullrequest_reviewer_change and plugin_pullrequest_reviewer_change_user tables. Part of story #14190: get email notifications on pull requests - first stage Change-Id: I1fe91ef0b1b03757f3db90c7d7875d01122a4a96

+232 −27
Thomas Gerbet (tgerbet) 2019-11-27 16:35
Thomas Gerbet (tgerbet) 2019-11-28 11:12
a506107a5a984d9f3e03a6273febf0a169661f68
499afdbf9cf9d9706aa4758b25cfc89e98941a90
git #tuleap/stable/a506107a5a984d9f3e03a6273febf0a169661f68

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/db/install.sql +11 −2 Go to diff View file
A plugins/pullrequest/db/mysql/updates/2019/201911271350_add_tables_reviewer_changes.php +101 −0 Go to diff View file
M plugins/pullrequest/db/uninstall.sql +2 −1 Go to diff View file
M plugins/pullrequest/include/PullRequest/REST/v1/PullRequestsResource.php +6 −1 Go to diff View file
M plugins/pullrequest/include/PullRequest/Reviewer/ReviewerDAO.php +58 −12 Go to diff View file
M plugins/pullrequest/include/PullRequest/Reviewer/ReviewerUpdater.php +13 −3 Go to diff View file
M plugins/pullrequest/phpunit/Reviewer/ReviewerUpdaterTest.php +31 −6 Go to diff View file
M plugins/pullrequest/tests/integration/ReviewerDAOTest.php +10 −2 Go to diff View file