Various issues are fixed in this commit: - the rest route that is called in the javascript should be made against project members ugroup and not current ugroup (We want to know if the user is project member). - the method PFUser->isMember() returns true when the user is site administrator. Therefore we cannot use it to ensure that the user is really member of the project. - the same for the rest route that was relying on isMember. Among other things left to the imagination of the reviewer, here are the things to test: - Go to a project » admin » groups » Project administrators. Try to add a site administrator that is not yet member of the project. A confirmation modal should appear and then the user should be member of the project and the project administrators ugroup. - Try to add a regular user that is not yet member of the project. Same behaviour than above. - Try to add a user that is already project member. No modal is displayed. The user is directly added to project administrators. - Call GET /user_groups/:ugroup_id/users with query parameter for all supported dynamic ugroups. Results should be consistent with the current status of ugroups members in the corresponding project. Change-Id: I80adf627f82918e1b3eab09d8541691c52af7295

+189 −14

Author

Nicolas Terray (nterray) 2017-12-15 15:31

Committer

Nicolas Terray (nterray) 2017-12-15 17:11

Hash a5295a651ceaba033603e28fdfa06048a7669596

Parent 7a961b319e34150d3f1cc683d94502d80d40ef81

Reference git #tuleap/stable/a5295a651ceaba033603e28fdfa06048a7669596