Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Refactoring: improve type hinting

Download Browse

No functional changes. - First of all, IRetrieveSemanticFromXML is now named IBuildSemanticFromXML to better reflect the intent. - Type hint is added and obsolete docblock is removed. - Add missing inheritance for TooltipFactory. - proper parameter name in snake case. - remove unused legacy mock builder. Part of story #12537 configure my burndown/up & sprint with a start date & end date Change-Id: If9acddebac7ac53f2eab6935e42994c1a3315c84

+119 −288
Nicolas Terray (nterray) 2019-07-17 21:17
Nicolas Terray (nterray) 2019-07-17 21:17
aa25a86bbf51e6cd83b4a25f7c1c0e2e5e4070f8
5e7874fb034ad23947fa45aa2e280d6073356893
git #tuleap/stable/aa25a86bbf51e6cd83b4a25f7c1c0e2e5e4070f8

Modified Files

Side by side diff
Inline diff
Name
M plugins/agiledashboard/include/AgileDashboard/Semantic/Semantic_InitialEffortFactory.class.php +5 −13 Go to diff View file
M plugins/agiledashboard/tests/AgileDashboardPluginTest.php +1 −1 Go to diff View file
M plugins/agiledashboard/tests/include/AgileDashboard/FormElement/MessageFetcherTest.php +16 −8 Go to diff View file
M plugins/cardwall/include/Semantic/CardFieldsFactory.class.php +3 −12 Go to diff View file
R plugins/tracker/include/Tracker/Semantic/IRetrieveSemanticFromXML.class.php Go to diff View file
M plugins/tracker/include/Tracker/Semantic/Timeframe/SemanticTimeframeFromXMLBuilder.php +5 −14 Go to diff View file
M plugins/tracker/include/Tracker/Semantic/Tracker_SemanticFactory.class.php +36 −24 Go to diff View file
M plugins/tracker/include/Tracker/Semantic/Tracker_Semantic_ContributorFactory.class.php +5 −13 Go to diff View file
M plugins/tracker/include/Tracker/Semantic/Tracker_Semantic_DescriptionFactory.class.php +5 −13 Go to diff View file
M plugins/tracker/include/Tracker/Semantic/Tracker_Semantic_StatusFactory.class.php +6 −14 Go to diff View file
M plugins/tracker/include/Tracker/Semantic/Tracker_Semantic_TitleFactory.class.php +5 −13 Go to diff View file
M plugins/tracker/include/Tracker/Tooltip/Tracker_TooltipFactory.class.php +17 −23 Go to diff View file
M plugins/tracker/tests/TrackerFactoryTest.php +0 −1 Go to diff View file
M plugins/tracker/tests/Tracker_SemanticFactoryTest.php +15 −23 Go to diff View file
D plugins/tracker/tests/builders/aMockSemanticStatusFactory.php +0 −68 Go to diff View file
D plugins/tracker/tests/builders/aMockSemanticTitleFactory.php +0 −48 Go to diff View file