Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Use ProgramForAdministrationIdentifier instead of int

Download Browse

Part of story #21793 configure Program Management No functional change expected in Program Management admin page Notes to reviewers: Using int has weaker guarantees because we could pass any number. Using the dedicated object, we are certain that the given project is not a Team and that current user is administrator of it. Change-Id: I4f88012a80a97bce1701df51447890c938a6b818

+193 −94
Joris MASSON (jmasson) 2021-07-13 18:22
Joris MASSON (jmasson) 2021-07-15 18:42
aa2c09fe9f32dd091984e0f9d5824d8dc1107137
9df1e941e979680f1b8a32931a3e447562c65432
git #tuleap/stable/aa2c09fe9f32dd091984e0f9d5824d8dc1107137

Modified Files

Side by side diff
Inline diff
Name
M plugins/program_management/include/Adapter/Program/Admin/CanPrioritizeItems/ProjectUGroupCanPrioritizeItemsPresentersBuilder.php +5 −4 Go to diff View file
M plugins/program_management/include/Adapter/Program/Admin/Configuration/ConfigurationChecker.php +3 −2 Go to diff View file
M plugins/program_management/include/Adapter/Program/Admin/PlannableTrackersConfiguration/PotentialPlannableTrackersConfigurationPresentersBuilder.php +4 −3 Go to diff View file
M plugins/program_management/include/Adapter/Program/Admin/PotentialTeam/PotentialTeamsBuilder.php +6 −5 Go to diff View file
M plugins/program_management/include/Adapter/Program/Admin/ProgramIncrementTrackerConfiguration/PotentialProgramIncrementTrackerConfigurationPresentersBuilder.php +3 −2 Go to diff View file
M plugins/program_management/include/DisplayAdminProgramManagementController.php +10 −11 Go to diff View file
M plugins/program_management/include/Domain/Program/Admin/CanPrioritizeItems/BuildProjectUGroupCanPrioritizeItemsPresenters.php +2 −1 Go to diff View file
M plugins/program_management/include/Domain/Program/Admin/PlannableTrackersConfiguration/BuildPotentialPlannableTrackersConfigurationPresenters.php +2 −1 Go to diff View file
M plugins/program_management/include/Domain/Program/Admin/PotentialTeam/BuildPotentialTeams.php +2 −1 Go to diff View file
M plugins/program_management/include/Domain/Program/Admin/ProgramAdminPresenter.php +5 −5 Go to diff View file
M plugins/program_management/include/Domain/Program/Admin/ProgramIncrementTrackerConfiguration/BuildPotentialProgramIncrementTrackerConfigurationPresenters.php +2 −1 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Admin/Configuration/ConfigurationCheckerTest.php +48 −24 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Admin/CanPrioritizeItems/ProjectUGroupCanPrioritizeItemsPresentersBuilderTest.php +16 −4 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Admin/PlannableTrackersConfiguration/PotentialPlannableTrackersConfigurationPresentersBuilderTest.php +20 −6 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Admin/PotentialTeam/PotentialTeamsBuilderTest.php +29 −9 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Admin/ProgramIncrementTrackerConfiguration/PotentialProgramIncrementTrackerConfigurationPresentersBuilderTest.php +27 −10 Go to diff View file
M plugins/program_management/tests/unit/Stub/BuildPotentialPlannableTrackersConfigurationPresentersStub.php +2 −1 Go to diff View file
M plugins/program_management/tests/unit/Stub/BuildPotentialProgramIncrementTrackerConfigurationPresentersStub.php +2 −1 Go to diff View file
M plugins/program_management/tests/unit/Stub/BuildPotentialTeamsStub.php +3 −2 Go to diff View file
M plugins/program_management/tests/unit/Stub/BuildProjectUGroupCanPrioritizeItemsPresentersStub.php +2 −1 Go to diff View file