stable

Clone or download

Read-only

refactoring: use named constructor pattern for ProgramTracker and TrackerCollection

part of story #21368 create mirrored iteration No functional change expected ProgramTracker is under heavy use so we can't turn its constructor to private yet. TrackerCollection can now only be built from Team projects' root milestones (=> Mirrored Program Increment trackers) In following patches, we can introduce a second named constructor to build a TrackerCollection from Mirrored Iteration trackers (Team project's N+1 level planning's milestone tracker) Notes to reviewer: - I took the opportunity to replace some mocks by PHPUnit mocking system. Sorry for the noise ! - I also changed the structure of the glossary to use titles instead of list bullet points. "Sprint" has been removed because it is the same thing as "Iteration" Change-Id: I3c9c816bf4e003b461feb6ee241f82d337c4f853

Modified Files

Name
M plugins/program_management/adr/glossary.md +52 −16 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/AsynchronousCreation/CreateProgramIncrementsTask.php +13 −11 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/AsynchronousCreation/TaskBuilder.php +1 −7 Go to diff View file
M plugins/program_management/include/Adapter/Program/PlanningAdapter.php +8 −1 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/CreationCheck/TimeboxCreatorChecker.php +14 −7 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/ProgramIncrementCollectionFactory.php +1 −18 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/TrackerCollection.php +28 −10 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/TrackerCollectionFactory.php +0 −9 Go to diff View file
M plugins/program_management/include/Domain/ProgramTracker.php +18 −22 Go to diff View file
A plugins/program_management/include/Domain/Team/MirroredTimebox/RetrieveRootPlanningMilestoneTracker.php +36 −0 Go to diff View file
M plugins/program_management/include/program_managementPlugin.php +4 −7 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/AsynchronousCreation/CreateProgramIncrementsTaskTest.php +1 −7 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/CreationCheck/RequiredFieldCheckerTest.php +55 −45 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/CreationCheck/SemanticCheckerTest.php +113 −121 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/CreationCheck/StatusSemanticCheckerTest.php +82 −102 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/CreationCheck/WorkflowCheckerTest.php +51 −35 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/PlanningAdapterTest.php +30 −20 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/AsynchronousCreation/ProgramIncrementsCreatorTest.php +48 −78 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/CreationCheck/TimeboxCreatorCheckerTest.php +52 −42 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/ProgramIncrement/ProgramIncrementCollectionFactoryTest.php +0 −18 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/TrackerCollectionTest.php +52 −42 Go to diff View file
A plugins/program_management/tests/unit/Domain/ProgramTrackerTest.php +53 −0 Go to diff View file
A plugins/program_management/tests/unit/Stub/RetrieveRootPlanningMilestoneTrackerStub.php +68 −0 Go to diff View file