Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

request #10319: Artifacts with a lot of attachments and a lot of comments take a long time to load

Download Browse

This contribution avoids to retrieve the same file informations multiple times from the database. To test, create an artifact, add a lot of attachments and comments. By profiling the code you will see a lot of calls to Tracker_FileInfoDao::searchById, this contribution reduces the number of needed calls to this method. Change-Id: I42498e65ce868210551ce4edb09af3dc1674c7fd

+43 −100
Thomas Gerbet (tgerbet) 2017-06-15 09:52
Thomas Gerbet (tgerbet) 2017-06-15 11:25
ab1cd1ddc940af0caca6832edcb8a2a0bc2e226a
1115c7cf54467a28e5ae7d1291425a39e5006667
git #tuleap/stable/ab1cd1ddc940af0caca6832edcb8a2a0bc2e226a

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/include/Tracker/FileInfoFactory.class.php +14 −3 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_File.class.php +16 −21 Go to diff View file
M plugins/tracker/include/Tracker/Tracker_FileInfo.class.php +5 −35 Go to diff View file
M plugins/tracker/tests/Tracker_FormElement_Field_FileTest.php +8 −41 Go to diff View file