Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

When status values is automatically choose, we do not check transition's

Download Browse

permissions Part of request #25353 Field dependencies and transitions rules are not check when the value is automatically selected This patch check if the user can see the transition before return the value as a possible value. To test it : - set up a Kanban for a tracker - In this tracker, doesn't authorize transitions to close values only for project admin - try to move a card into archived colomn --> Without the patch, you should have the old error --> with the patch, you should have "No possible value found regarding your configuration. Please check your transition and field dependencies." Change-Id: I6d742b3907f9adcb567aa45489783c26edc32bef

+368 −251
Lorentz Romain (lorentzr) 2022-03-18 13:40
Lorentz Romain (lorentzr) 2022-03-24 17:11
ab2a7be9b2f4c29007f2ce5f5ca664c162c85922
30f5c994580e0a37040ca809647237dc34adcaad
git #tuleap/stable/ab2a7be9b2f4c29007f2ce5f5ca664c162c85922

Modified Files

Side by side diff
Inline diff
Name
M plugins/agiledashboard/include/AgileDashboard/REST/v1/Kanban/KanbanResource.php +5 −0 Go to diff View file
M plugins/gitlab/include/gitlabPlugin.php +15 −10 Go to diff View file
M plugins/taskboard/include/REST/v1/Cell/CardMappedFieldUpdater.php +10 −2 Go to diff View file
M plugins/taskboard/tests/unit/REST/v1/Cell/CardMappedFieldUpdaterTest.php +6 −6 Go to diff View file
M plugins/testmanagement/include/TestManagement/REST/v1/CampaignsResource.class.php +5 −0 Go to diff View file
M plugins/testmanagement/include/testmanagementPlugin.php +4 −0 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Artifact.php +5 −0 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Renderer/FieldsDataFromRequestRetriever.php +5 −4 Go to diff View file
M plugins/tracker/include/Tracker/Rule/FirstValidValueAccordingToDependenciesRetriever.php +1 −1 Go to diff View file
M plugins/tracker/include/Tracker/Semantic/Status/Done/DoneValueRetriever.php +1 −1 Go to diff View file
M plugins/tracker/include/Tracker/Semantic/Status/StatusValueRetriever.php +2 −2 Go to diff View file
M plugins/tracker/include/Workflow/FirstPossibleValueInListRetriever.php +6 −2 Go to diff View file
M plugins/tracker/include/Workflow/ValidValuesAccordingToTransitionsRetriever.php +19 −5 Go to diff View file
M plugins/tracker/include/Workflow/Workflow.class.php +3 −2 Go to diff View file
M plugins/tracker/tests/unit/Tracker/Artifact/Renderer/FieldsDataFromRequestRetrieverTest.php +7 −2 Go to diff View file
M plugins/tracker/tests/unit/Tracker/Semantic/Status/Done/DoneValueRetrieverTest.php +24 −43 Go to diff View file
M plugins/tracker/tests/unit/Tracker/Semantic/Status/StatusValueRetrieverTest.php +41 −77 Go to diff View file
M plugins/tracker/tests/unit/Workflow/FirstPossibleValueInListRetrieverTest.php +141 −59 Go to diff View file
M plugins/tracker/tests/unit/Workflow/ValidValuesAccordingToTransitionsRetrieverTest.php +68 −35 Go to diff View file