Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Convert Project admin Add and Delete App controllers to PSR15

Download Browse

Part of story #14543 have OAuth2 user settings No functional change expected. Apps can be created and deleted the same way in Project administration. This is just a technical change to have more PSR-15 compatible controllers. This allows to split up controllers by reusing small middlewares. Change-Id: Ic90e9a81d07c5e1f38b44feed09d8781009e073f

+507 −216
Joris MASSON (jmasson) 2020-03-19 18:05
Joris MASSON (jmasson) 2020-03-20 12:46
af3fae08a4d2e66ca480f547910ec1fbf26f9be7
8e369cfd157d5bf9d8eb89f46192f8cadffe4ef2
git #tuleap/stable/af3fae08a4d2e66ca480f547910ec1fbf26f9be7

Modified Files

Side by side diff
Inline diff
Name
M plugins/oauth2_server/include/ProjectAdmin/AddAppController.php +68 −53 Go to diff View file
M plugins/oauth2_server/include/ProjectAdmin/DeleteAppController.php +36 −53 Go to diff View file
M plugins/oauth2_server/include/oauth2_serverPlugin.php +50 −2 Go to diff View file
M plugins/oauth2_server/phpunit/ProjectAdmin/AddAppControllerTest.php +48 −54 Go to diff View file
M plugins/oauth2_server/phpunit/ProjectAdmin/DeleteAppControllerTest.php +49 −54 Go to diff View file
A src/common/Project/Admin/Routing/RejectNonProjectAdministratorMiddleware.php +63 −0 Go to diff View file
A src/common/Project/Routing/ProjectRetrieverMiddleware.php +55 −0 Go to diff View file
A tests/phpunit/common/Project/Admin/Routing/RejectNonProjectAdministratorMiddlewareTest.php +84 −0 Go to diff View file
A tests/phpunit/common/Project/Routing/ProjectRetrieverMiddlewareTest.php +54 −0 Go to diff View file