Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Do not raise perms error when the transition is not valid

Download Browse

Part of story #9096: Define comment as mandatory in a tracker workflow transition When an artifact is updated, and the condition for the transition is not respected, then the feedback always says that this is because permissions are not respected, which is not always right. On a transition with mandatory comment, you should not have a "perms" error if the comment is empty while updating the artifact. You should still have the "perms" error if you don't have the right to pass the transition though. (This bug is not present in modal v2) Change-Id: I51e66b45574eaded721a5617303b155980966c8a

+24 −19
Nicolas Terray (nterray) 2016-08-05 16:33
Nicolas Terray (nterray) 2016-08-08 09:30
b11b9e97fa0ccbf5e75f37e2f7b5859b3fd760e0
03ce4d036eeb5b04991b70074239fa78e4055d90
git #tuleap/stable/b11b9e97fa0ccbf5e75f37e2f7b5859b3fd760e0

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/include/autoload.php +3 −5 Go to diff View file
M plugins/tracker/include/workflow/Transition/Condition/Permissions.class.php +10 −5 Go to diff View file
R plugins/tracker/include/workflow/Transition/Condition/Permissions/PermissionTransitionViolationException.class.php Go to diff View file
M plugins/tracker/include/workflow/Workflow.class.php +8 −6 Go to diff View file
M plugins/tracker/tests/workflow/WorkflowTest.php +3 −3 Go to diff View file