Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Disable per repo permissions form when fine grained perms are used

Download Browse

This is part of story #8419: have permissions per tags/branches How to test: In a Git repository's settings, in Access control: - When you enable fine-grained permissions, then "Write" and "Rewind" repository-wide permission selectboxes will be disabled. - When you disable fine-grained permissions, then "Write" and "Rewind" selectboxes will be enabled again. - Given you did not select anything in either repository-wide "Write" or "Rewind" permissions, when you disable fine-grained permissions, then an error will be displayed and the permissions won't be saved. In Git's project-wide administration, in Default git settings: - When you enable fine-grained permissions, then "Write" and "Rewind" repository-wide permission selectboxes will be disabled. - When you disable fine-grained permissions, then "Write" and "Rewind" selectboxes will be enabled again. - Given you did not select anything in project-wide "Write" permissions, when you disable fine-grained permissions, then an error will be displayed and the permissions won't be saved. Change-Id: I157da87aab3f08d8a57c387e40e583c3d6001304

+166 −38
Joris MASSON (jmasson) 2016-06-16 16:24
Joris MASSON (jmasson) 2016-06-16 16:54
b36d9ef90db6e4aa5ccbe2f69fb21ac891a82458
92e7953cfe9f7d8fb345b022ed951928415f9f03
git #tuleap/stable/b36d9ef90db6e4aa5ccbe2f69fb21ac891a82458

Modified Files

Side by side diff
Inline diff
Name
M plugins/git/include/Git.class.php +2 −1 Go to diff View file
M plugins/git/include/GitActions.class.php +27 −2 Go to diff View file
M plugins/git/include/GitPermissionsManager.class.php +56 −18 Go to diff View file
M plugins/git/include/GitPresenters/AccessControlPresenter.class.php +3 −1 Go to diff View file
M plugins/git/include/GitPresenters/AdminDefaultSettingsPresenter.php +2 −0 Go to diff View file
M plugins/git/include/REST/v1/RepositoryResource.class.php +5 −1 Go to diff View file
M plugins/git/include/gitPlugin.class.php +2 −1 Go to diff View file
M plugins/git/site-content/en_US/git.tab +2 −0 Go to diff View file
M plugins/git/site-content/fr_FR/git.tab +9 −6 Go to diff View file
M plugins/git/templates/access-control.mustache +24 −3 Go to diff View file
M plugins/git/tests/GitActionsTest.php +8 −4 Go to diff View file
M plugins/git/tests/GitPermissionsManagerTest.php +2 −1 Go to diff View file
M plugins/git/www/scripts/permissions.js +24 −0 Go to diff View file