Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

request #11502 Do not query OPTIONS artifact_temporary_files when there is no File field

Download Browse

I also took this opportunity to move code related to file fields out of AngularJS and into ES modules. How to test: - make post-checkout, then test with Planning-v2 or TestManagement (as Kanban does not use Artifact creation) - When you create/edit an artifact from a tracker without any File attachment field, then there should not be any query to OPTIONS artifact_temporary_files. - When you create/edit an artifact with File attachment field, there should be a query. You should have the current state of your File quota on the modal footer. - No change on File upload expected Change-Id: I4154edf8c087c66d3d0168f232edf4ee32003763

+226 −166
Joris MASSON (jmasson) 2018-05-22 12:07
Joris MASSON (jmasson) 2018-05-28 14:26
b41be62346d879388d32dd563eb505c3c03fd4a6
1c5d07aaf5e509cf4c7cd3957ec29847f75feab2
git #tuleap/stable/b41be62346d879388d32dd563eb505c3c03fd4a6

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/www/scripts/angular-artifact-modal/src/index.spec.js +2 −0 Go to diff View file
M plugins/tracker/www/scripts/angular-artifact-modal/src/quota-display/quota-display-controller.js +15 −22 Go to diff View file
M plugins/tracker/www/scripts/angular-artifact-modal/src/quota-display/quota-display-directive.js +5 −7 Go to diff View file
M plugins/tracker/www/scripts/angular-artifact-modal/src/quota-display/quota-display.js +4 −9 Go to diff View file
M plugins/tracker/www/scripts/angular-artifact-modal/src/tuleap-artifact-modal-controller.js +10 −20 Go to diff View file
M plugins/tracker/www/scripts/angular-artifact-modal/src/tuleap-artifact-modal-controller.spec.js +13 −32 Go to diff View file
A plugins/tracker/www/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/file-field/file-field-detector.js +12 −0 Go to diff View file
A plugins/tracker/www/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/file-field/file-field-detector.spec.js +41 −0 Go to diff View file
M plugins/tracker/www/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/file-field/file-field.js +0 −2 Go to diff View file
A plugins/tracker/www/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/file-field/file-upload-rules-state.js +24 −0 Go to diff View file
A plugins/tracker/www/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/file-field/file-upload-rules-state.spec.js +64 −0 Go to diff View file
D plugins/tracker/www/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/file-field/file-upload-rules-value.js +0 −6 Go to diff View file
M plugins/tracker/www/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/file-field/file-upload-service.js +3 −9 Go to diff View file
M plugins/tracker/www/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/file-field/file-upload-service.spec.js +9 −10 Go to diff View file
M plugins/tracker/www/scripts/angular-artifact-modal/src/tuleap-artifact-modal-service.js +6 −20 Go to diff View file
M plugins/tracker/www/scripts/angular-artifact-modal/src/tuleap-artifact-modal-service.spec.js +18 −28 Go to diff View file
M plugins/tracker/www/scripts/angular-artifact-modal/src/tuleap-artifact-modal.tpl.html +0 −1 Go to diff View file