Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

fix: Fatal error in mention tooltips

Download Browse

part of request #27932 Replace PFUser::getName and PFUser::getUnixName with PFUser::getUserName How to test: - Without this patch, hover your mouse over a `@username` mention, for example in Tracker artifact view. You should get an exception with a stack trace in codendi_syslog - With it, the tooltip correctly shows the user's avatar image, full name and username, id and email. Introduced by 1026a3805d1194115ca0f6a20218bd8d23829ef1 Note: instead of just fixing, I added presenters. If/when we rename something else, we can look for usage in PHP code instead of mustache template (where we don't have any context). Change-Id: I8ab78d53dedb2fc4c7f0838db98d990988dc9365

+189 −12
Joris MASSON (jmasson) 2022-08-12 17:37
Joris MASSON (jmasson) 2022-08-12 17:47
b4c3aa0f8b541e56531740586e1c6bc32ad8042f
66a1578d0f6e5cdb0b95265f89bb3e6a255b714b
git #tuleap/stable/b4c3aa0f8b541e56531740586e1c6bc32ad8042f

Modified Files

Side by side diff
Inline diff
Name
M src/common/User/Profile/ProfileAsJSONForTooltipController.php +2 −2 Go to diff View file
A src/common/User/Profile/UserTooltipBodyPresenter.php +40 −0 Go to diff View file
A src/common/User/Profile/UserTooltipTitlePresenter.php +41 −0 Go to diff View file
M src/common/User/Profile/tooltip-body.mustache +2 −2 Go to diff View file
M src/common/User/Profile/tooltip-title.mustache +3 −5 Go to diff View file
M tests/unit/common/User/Profile/ProfileAsJSONForTooltipControllerTest.php +10 −3 Go to diff View file
A tests/unit/common/User/Profile/UserTooltipBodyPresenterTest.php +44 −0 Go to diff View file
A tests/unit/common/User/Profile/UserTooltipTitlePresenterTest.php +47 −0 Go to diff View file