Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: Migrate diff-mode-state and inline-comment-positions to TypeScript

Download Browse

part of request #29602 Migrate pullrequest file-diffs to TypeScript Nothing special to say about diff-mode-state. inline-comment-positions.js has been removed because the constants it was exporting already exists in our TypeScript code, so let's use them -- No functional change expected Change-Id: If5cb7343dd72d53a2da97bdd79c54013abc69b0a

+21 −33
Thomas Gorka (tgorka) 2022-11-10 10:57
Thomas Gorka (tgorka) 2022-11-10 11:13
b4c936dc1305be339b0660585803145a79c3197f
e92bd094a4b4265e5f3e61c22a5b58e85a80af55
git #tuleap/stable/b4c936dc1305be339b0660585803145a79c3197f

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentPresenter.ts +2 −1 Go to diff View file
R plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-mode-state.js Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-diff-component.js +11 −6 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/unidiff-component.js +6 −3 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/file-diff-component.js +1 −1 Go to diff View file
D plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/inline-comment-positions.js +0 −21 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/files/files-controller.js +1 −1 Go to diff View file