stable

Clone or download

Read-only

Adapters must never be mocked in tests

part of request #23433 Clean program management tests No functional changes An easy way to be sure that they won't be mocked is to declare the classes as final You can check with a find that very file contains final with following command line (to be run under include/Adapter) the few remaining files must be interfaces find . -type f -not -ipath '.php' -exec grep -H -E -o -c "final" {} \; | grep 0 Change-Id: Ifa90a4860e982b3c6b8b4c0fad48bc3f66497d5e

Modified Files

Name
M plugins/program_management/include/Adapter/Program/Backlog/Rank/FeaturesRankOrderer.php +1 −1 Go to diff View file
M plugins/program_management/include/Adapter/Program/Feature/Content/ContentDao.php +1 −1 Go to diff View file
M plugins/program_management/include/Adapter/Program/Feature/FeatureDAO.php +1 −1 Go to diff View file
M plugins/program_management/include/Adapter/Program/Feature/FeatureRepresentationBuilder.php +1 −1 Go to diff View file
M plugins/program_management/include/Adapter/Program/Feature/Links/ArtifactsLinkedToParentDao.php +1 −1 Go to diff View file
M plugins/program_management/include/Adapter/Program/Plan/CanPrioritizeFeaturesDAO.php +1 −1 Go to diff View file
M plugins/program_management/include/Adapter/ProjectAdmin/PermissionPerGroupSectionBuilder.php +7 −28 Go to diff View file
A plugins/program_management/include/Domain/Program/Backlog/Feature/Links/VerifyIsLinkedToProgramIncrement.php +29 −0 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/ProgramIncrementTracker/SearchProgramIncrementLinkedToFeature.php +0 −2 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/TopBacklog/TopBacklogStore.php +0 −2 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/TopBacklog/ProcessTopBacklogChangeTest.php +5 −7 Go to diff View file
M plugins/program_management/tests/unit/Adapter/ProjectAdmin/PermissionPerGroupSectionBuilderTest.php +19 −16 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/CreationCheck/TimeboxCreatorCheckerTest.php +64 −75 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Team/TeamCreatorTest.php +8 −13 Go to diff View file
M plugins/program_management/tests/unit/Stub/BuildPlanningStub.php +1 −1 Go to diff View file
M plugins/program_management/tests/unit/Stub/ExtractXMLConfigStub.php +1 −1 Go to diff View file
A plugins/program_management/tests/unit/Stub/OrderFeatureRankStub.php +50 −0 Go to diff View file
A plugins/program_management/tests/unit/Stub/TeamStoreStub.php +49 −0 Go to diff View file
A plugins/program_management/tests/unit/Stub/VerifyIsLinkedToProgramIncrementStub.php +50 −0 Go to diff View file
A plugins/program_management/tests/unit/Stub/VerifyRequiredFieldsLimitedToSynchronizedFieldsStub.php +57 −0 Go to diff View file
A plugins/program_management/tests/unit/Stub/VerifySemanticsAreConfiguredStub.php +53 −0 Go to diff View file
A plugins/program_management/tests/unit/Stub/VerifySynchronizedFieldsAreNotUsedInWorkflowStub.php +51 −0 Go to diff View file