stable
Clone or download
Read-only
The usage of require_once with a path that cannot be resolved during a static analysis does not play well with the taint analysis feature of Psalm [0]. It's also a good opportunity to do a much needed cleanup. As it allows Psalm to better analyze the code a lot of new errors are found. The baseline has been updated to integrated them. Administrators having customized site-content files will need to check and update their files if a configuration setting value is accessed via $GLOBALS. Part request #15015: Initiate usage of Psalm taint analysis feature [0] https://github.com/vimeo/psalm/issues/3691 Change-Id: Icc3c0edaa029051ea85641b9474c2e5623d8e519
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/crosstracker/tests/unit/CrossTracker/CrossTrackerReportFactoryTest.php | +0 | −6 | Go to diff View file |
| M | plugins/crosstracker/tests/unit/CrossTracker/Report/Query/Advanced/InvalidSemantic/MetadataUsageCheckerTest.php | +0 | −6 | Go to diff View file |
| M | plugins/docman/include/ApprovalTable/NotificationCycle.class.php | +8 | −8 | Go to diff View file |
| M | plugins/docman/include/ApprovalTable/Reminder.class.php | +2 | −2 | Go to diff View file |
| M | plugins/docman/include/Docman_Controller.class.php | +1 | −1 | Go to diff View file |
| M | plugins/docman/include/Docman_HTTPController.class.php | +1 | −1 | Go to diff View file |
| M | plugins/docman/include/docmanPlugin.php | +2 | −2 | Go to diff View file |
| M | plugins/docman/include/view/Docman_View_ItemDetailsSectionApprovalCreate.class.php | +1 | −1 | Go to diff View file |
| M | plugins/docman/tests/unit/NotificationsManager_MoveTest.php | +2 | −10 | Go to diff View file |
| M | plugins/forumml/include/ListMailsController.php | +1 | −1 | Go to diff View file |
| M | plugins/forumml/include/forumml_utils.php | +1 | −1 | Go to diff View file |
| M | plugins/git/bin/gl-admin-housekeeping.php | +1 | −1 | Go to diff View file |
| M | plugins/git/include/GitBackend.class.php | +1 | −1 | Go to diff View file |
| M | plugins/git/include/GitRepositoryManager.class.php | +3 | −3 | Go to diff View file |
| M | plugins/git/include/Git_Backend_Gitolite.class.php | +2 | −2 | Go to diff View file |
| M | plugins/git/include/Git_GitoliteDriver.class.php | +1 | −1 | Go to diff View file |
| M | plugins/git/include/gitPlugin.php | +1 | −1 | Go to diff View file |
| M | plugins/git/tests/integration/GitXmlImporterTest.php | +13 | −10 | Go to diff View file |
| M | plugins/git/tests/integration/Gitolite/GitoliteDriverTest.php | +0 | −2 | Go to diff View file |
| M | plugins/git/tests/integration/Gitolite/GitoliteTestCase.php | +3 | −3 | Go to diff View file |
| M | plugins/git/tests/unit/Git/Gitolite/ConfigPermissionsSerializerFineGrainedPermissionsTest.php | +0 | −6 | Go to diff View file |
| M | plugins/ldap/include/LDAP_SyncMail.class.php | +1 | −1 | Go to diff View file |
| M | plugins/ldap/include/ldapPlugin.php | +2 | −2 | Go to diff View file |
| M | plugins/ldap/tests/unit/LDAPBackendSVNTest.php | +9 | −2 | Go to diff View file |
| M | plugins/ldap/tests/unit/LDAPDirectorySynchronizationTest.php | +2 | −18 | Go to diff View file |
| M | plugins/mediawiki/bin/mw-maintenance-wrapper.php | +1 | −1 | Go to diff View file |
| M | plugins/mediawiki/fusionforge/FusionForge.php | +3 | −3 | Go to diff View file |
| M | plugins/mediawiki/include/Migration/MediawikiMigrator.php | +1 | −1 | Go to diff View file |
| M | plugins/mediawiki/include/mediawikiPlugin.php | +1 | −1 | Go to diff View file |
| M | plugins/pluginsadministration/include/PluginsAdministrationViews.class.php | +2 | −2 | Go to diff View file |
| M | plugins/proftpd/include/ProFTPd/SystemEvent/PROFTPD_DIRECTORY_CREATE.class.php | +1 | −1 | Go to diff View file |
| M | plugins/proftpd/include/ProFTPd/SystemEvent/PROFTPD_UPDATE_ACL.class.php | +1 | −1 | Go to diff View file |
| M | plugins/proftpd/tests/unit/ProFTPd/SystemEvent/PROFTPD_DIRECTORY_CREATETest.php | +4 | −5 | Go to diff View file |
| M | plugins/proftpd/tests/unit/ProFTPd/SystemEvent/PROFTPD_UPDATE_ACLTest.php | +3 | −9 | Go to diff View file |
| M | plugins/statistics/include/Statistics_DiskUsageManager.class.php | +3 | −3 | Go to diff View file |
| M | plugins/svn/include/SVN/AccessControl/AccessControlPresenter.php | +2 | −1 | Go to diff View file |
| M | plugins/testmanagement/tests/unit/TestManagement/AdminControllerTest.php | +0 | −13 | Go to diff View file |
| M | plugins/testmanagement/tests/unit/TestManagement/CampaignCreatorTest.php | +0 | −4 | Go to diff View file |
| M | plugins/timetracking/tests/unit/Time/TimetrackingOverviewRepresentationsBuilderTest.php | +0 | −3 | Go to diff View file |
| M | plugins/tracker/include/Tracker/DateReminder/Tracker_DateReminderManager.class.php | +4 | −4 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_ArtifactId.class.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_File.class.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_PerTrackerArtifactIdclass.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Migration/MailLogger.class.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Tracker.class.php | +2 | −2 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/FormElement/ArtifactLinkValidatorTest.php | +2 | −16 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/Report/TrackerReportExtractorTest.php | +0 | −6 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/TrackerPermissionsTest.php | +0 | −2 | Go to diff View file |
| M | plugins/tracker_date_reminder/include/ArtifactDateReminderFactory.class.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker_date_reminder/include/tracker_date_reminderPlugin.php | +1 | −1 | Go to diff View file |
| M | plugins/webdav/include/Authentication/HeadersSender.php | +1 | −1 | Go to diff View file |
| M | plugins/webdav/include/BrowserPlugin.class.php | +6 | −6 | Go to diff View file |
| M | plugins/webdav/include/FS/WebDAVFRSRelease.class.php | +1 | −1 | Go to diff View file |
| M | plugins/webdav/include/WebDAVUtils.class.php | +1 | −1 | Go to diff View file |
| M | plugins/webdav/include/Webdav_URLVerification.class.php | +1 | −1 | Go to diff View file |
| M | plugins/webdav/include/webdavPlugin.php | +1 | −1 | Go to diff View file |
| M | plugins/webdav/tests/unit/WebDAVDocmanDocumentTest.php | +2 | −14 | Go to diff View file |
| M | plugins/webdav/tests/unit/WebDAVDocmanFileTest.php | +2 | −14 | Go to diff View file |
| M | plugins/webdav/tests/unit/WebDAVFRSReleaseTest.php | +15 | −20 | Go to diff View file |
| M | plugins/webdav/tests/unit/WebdavURLVerificationTest.php | +13 | −21 | Go to diff View file |
| M | site-content/en_US/account/new_account_email.txt | +6 | −6 | Go to diff View file |
| M | site-content/en_US/admin/new_account_email.txt | +8 | −8 | Go to diff View file |
| M | site-content/en_US/contact/contact.txt | +1 | −1 | Go to diff View file |
| M | site-content/en_US/cvs/intro.txt | +3 | −3 | Go to diff View file |
| M | site-content/en_US/file/qrs_attach_file.txt | +2 | −2 | Go to diff View file |
| M | site-content/en_US/include/add_user_to_group_email.txt | +2 | −2 | Go to diff View file |
| M | site-content/en_US/include/new_user_email.txt | +4 | −4 | Go to diff View file |
| M | site-content/en_US/layout/footer_cli.php | +1 | −1 | Go to diff View file |
| M | site-content/en_US/mail/addlist_intro.txt | +1 | −1 | Go to diff View file |
| M | site-content/en_US/mail/html_template.php | +1 | −1 | Go to diff View file |
| M | site-content/en_US/project/tos.txt | +37 | −37 | Go to diff View file |
| M | site-content/en_US/tos/privacy.txt | +35 | −35 | Go to diff View file |
| M | site-content/fr_FR/account/new_account_email.txt | +6 | −6 | Go to diff View file |
| M | site-content/fr_FR/admin/new_account_email.txt | +8 | −8 | Go to diff View file |
| M | site-content/fr_FR/contact/contact.txt | +1 | −1 | Go to diff View file |
| M | site-content/fr_FR/cvs/intro.txt | +2 | −2 | Go to diff View file |
| M | site-content/fr_FR/file/qrs_attach_file.txt | +2 | −2 | Go to diff View file |
| M | site-content/fr_FR/include/add_user_to_group_email.txt | +4 | −4 | Go to diff View file |
| M | site-content/fr_FR/include/new_user_email.txt | +4 | −4 | Go to diff View file |
| M | site-content/fr_FR/layout/footer_cli.php | +1 | −1 | Go to diff View file |
| M | site-content/fr_FR/mail/addlist_intro.txt | +1 | −1 | Go to diff View file |
| M | site-content/fr_FR/project/tos.txt | +44 | −44 | Go to diff View file |
| M | site-content/fr_FR/tos/privacy.txt | +33 | −33 | Go to diff View file |
| M | src/common/Config/ForgeConfig.php | +2 | −4 | Go to diff View file |
| M | src/common/FRS/FRSFile.class.php | +1 | −2 | Go to diff View file |
| M | src/common/FRS/FRSFileFactory.class.php | +5 | −11 | Go to diff View file |
| M | src/common/FRS/FRSReleaseFactory.class.php | +1 | −3 | Go to diff View file |
| M | src/common/FRS/FileModuleMonitorFactory.class.php | +1 | −1 | Go to diff View file |
| M | src/common/Project/Admin/ProjectDetails/ProjectDetailsController.php | +1 | −1 | Go to diff View file |
| M | src/common/Project/Group.class.php | +1 | −1 | Go to diff View file |
| M | src/common/Project/ProjectCreator.class.php | +6 | −6 | Go to diff View file |
| M | src/common/Project/Service/ServiceCreator.php | +1 | −1 | Go to diff View file |
| M | src/common/Project/Service/ServiceLinkDataBuilder.php | +1 | −1 | Go to diff View file |
| M | src/common/Service/ServiceCreator.php | +1 | −1 | Go to diff View file |
| M | src/common/User/LoginController.class.php | +1 | −1 | Go to diff View file |
| M | src/common/User/User.class.php | +1 | −1 | Go to diff View file |
| M | src/common/User/UserManager.class.php | +1 | −1 | Go to diff View file |
| M | src/common/Widget/Widget_MyAdmin.class.php | +2 | −2 | Go to diff View file |
| M | src/common/Widget/Widget_ProjectPublicAreas.class.php | +2 | −2 | Go to diff View file |
| M | src/common/account/RegisterPresenter.class.php | +1 | −1 | Go to diff View file |
| M | src/common/admin/AdminSidebarPresenterBuilder.php | +1 | −1 | Go to diff View file |
| M | src/common/admin/ProjectCreation/ProjectFieldsUpdateController.php | +1 | −1 | Go to diff View file |
| M | src/common/backend/BackendAliases.class.php | +4 | −4 | Go to diff View file |
| M | src/common/backend/BackendCVS.class.php | +27 | −27 | Go to diff View file |
| M | src/common/backend/BackendMailingList.class.php | +8 | −8 | Go to diff View file |
| M | src/common/backend/BackendSVN.class.php | +4 | −4 | Go to diff View file |
| M | src/common/backend/BackendSystem.class.php | +5 | −5 | Go to diff View file |
| M | src/common/include/ForgeUpgradeConfig.class.php | +2 | −2 | Go to diff View file |
| M | src/common/include/URL.class.php | +2 | −2 | Go to diff View file |
| M | src/common/language/BaseLanguage.class.php | +8 | −8 | Go to diff View file |
| M | src/common/layout/Layout.class.php | +5 | −5 | Go to diff View file |
| M | src/common/layout/ThemeManager.class.php | +1 | −1 | Go to diff View file |
| M | src/common/mail/MassmailSender.class.php | +1 | −1 | Go to diff View file |
| M | src/common/plugin/Plugin.class.php | +12 | −12 | Go to diff View file |
| M | src/common/plugin/PluginFactory.class.php | +1 | −1 | Go to diff View file |
| M | src/common/plugin/PluginManager.class.php | +15 | −15 | Go to diff View file |
| M | src/common/svn/SVN_Apache_SvnrootConf.class.php | +1 | −1 | Go to diff View file |
| M | src/common/svn/general-settings/SVN_GeneralSettingsPresenter.php | +2 | −2 | Go to diff View file |
| M | src/common/system_event/SystemEvent.class.php | +1 | −1 | Go to diff View file |
| M | src/common/system_event/include/SystemEvent_COMPUTE_MD5SUM.class.php | +2 | −2 | Go to diff View file |
| M | src/common/tracker/Artifact.class.php | +56 | −56 | Go to diff View file |
| M | src/common/valid/Rule.class.php | +2 | −2 | Go to diff View file |
| M | src/common/wiki/lib/WikiAttachment.class.php | +1 | −1 | Go to diff View file |
| M | src/common/wiki/lib/WikiAttachmentRevision.class.php | +4 | −4 | Go to diff View file |
| M | src/common/wiki/lib/WikiCloner.class.php | +6 | −6 | Go to diff View file |
| M | src/common/wiki/lib/WikiPageWrapper.class.php | +1 | −1 | Go to diff View file |
| M | src/themes/BurningParrot/include/HeaderPresenterBuilder.php | +1 | −1 | Go to diff View file |
| M | src/www/account/deleted.php | +1 | −1 | Go to diff View file |
| M | src/www/account/lostpw-confirm.php | +4 | −4 | Go to diff View file |
| M | src/www/account/register.php | +8 | −8 | Go to diff View file |
| M | src/www/admin/approve_pending_users.php | +4 | −4 | Go to diff View file |
| M | src/www/admin/index.php | +3 | −3 | Go to diff View file |
| M | src/www/admin/news/index.php | +1 | −1 | Go to diff View file |
| M | src/www/admin/show_pending_documents.php | +3 | −3 | Go to diff View file |
| M | src/www/admin/usergroup.php | +2 | −2 | Go to diff View file |
| M | src/www/file/confirm_download.php | +1 | −1 | Go to diff View file |
| M | src/www/file/file_utils.php | +6 | −6 | Go to diff View file |
| M | src/www/forum/admin/index.php | +1 | −1 | Go to diff View file |
| M | src/www/forum/forum.php | +2 | −2 | Go to diff View file |
| M | src/www/forum/forum_utils.php | +6 | −6 | Go to diff View file |
| M | src/www/include/html.php | +4 | −4 | Go to diff View file |
| M | src/www/include/pre.php | +4 | −5 | Go to diff View file |
| M | src/www/include/proj_email.php | +6 | −6 | Go to diff View file |
| M | src/www/include/utils.php | +8 | −8 | Go to diff View file |
| M | src/www/mail/admin/index.php | +5 | −5 | Go to diff View file |
| M | src/www/my/rmproject.php | +3 | −3 | Go to diff View file |
| M | src/www/news/admin/index.php | +2 | −2 | Go to diff View file |
| M | src/www/news/index.php | +1 | −1 | Go to diff View file |
| M | src/www/news/news_utils.php | +14 | −14 | Go to diff View file |
| M | src/www/project/export/project_export_utils.php | +1 | −1 | Go to diff View file |
| M | src/www/soap/frs/frs.php | +2 | −2 | Go to diff View file |
| M | src/www/softwaremap/trove_list.php | +1 | −1 | Go to diff View file |
| M | src/www/svn/svn_intro.php | +4 | −2 | Go to diff View file |
| M | src/www/themes/FlamingParrot/FlamingParrot_Theme.class.php | +2 | −2 | Go to diff View file |
| M | tests/integration/tests/Backend/BackendCVSTest.php | +60 | −54 | Go to diff View file |
| M | tests/integration/tests/Backend/BackendSVNTest.php | +44 | −34 | Go to diff View file |
| M | tests/integration/tests/Backend/BackendSystemTest.php | +27 | −15 | Go to diff View file |
| M | tests/integration/tests/ProjectCreationTest.php | +14 | −6 | Go to diff View file |
| M | tests/lib/TestDataBuilder.php | +0 | −1 | Go to diff View file |
| M | tests/psalm/tuleap-baseline.xml | +752 | −63 | Go to diff View file |
| M | tests/unit/common/Backend/BackendAliasesTest.php | +4 | −5 | Go to diff View file |
| M | tests/unit/common/Collection/CollectionTest.php | +0 | −1 | Go to diff View file |
| M | tests/unit/common/FRS/FRSFileFactoryTest.php | +79 | −87 | Go to diff View file |
| M | tests/unit/common/FRS/FRSXMLImporterTest.php | +4 | −19 | Go to diff View file |
| M | tests/unit/common/Include/URLTest.php | +7 | −8 | Go to diff View file |
| M | tests/unit/common/Plugin/PluginManagerTest.php | +5 | −5 | Go to diff View file |
| M | tests/unit/common/Plugin/PluginTest.php | +86 | −96 | Go to diff View file |
| M | tests/unit/common/Project/Service/ServicePOSTDataBuilderTest.php | +1 | −6 | Go to diff View file |
| M | tests/unit/common/Project/UGroupManagerTest.php | +0 | −4 | Go to diff View file |
| M | tests/unit/common/language/BaseLanguageTest.php | +16 | −23 | Go to diff View file |
| M | tests/unit/common/layout/LayoutTest.php | +2 | −7 | Go to diff View file |
| M | tests/unit/common/mail/MailBuilderTest.php | +3 | −3 | Go to diff View file |
| M | tests/unit/common/svn/SVN_Apache_SvnrootConfTest.php | +6 | −17 | Go to diff View file |
| M | tests/unit/common/valid/Rule_EmailTest.php | +5 | −10 | Go to diff View file |