stable
Clone or download
Read-only
Object based events are easier to deal with. This refactoring introduce a behaviour change. For plugins that take over the authentication (eg. ldap), there is no longer a difference between 'login exists but password is wrong' and 'login do not exists'. In practice this shouldn't change anything as the interface doesn't make any difference and it's a bad security practice to distinguish the 2 cases anyway. Part of request #16607 Allow ldap login when openidconnect client is used Change-Id: Iec6b177b2348240c7a8d946535e2c525f76e0e56
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/dynamic_credentials/include/dynamic_credentialsPlugin.php | +8 | −5 | Go to diff View file |
| M | plugins/ldap/include/LDAP_UserManager.class.php | +2 | −3 | Go to diff View file |
| M | plugins/ldap/include/ldapPlugin.php | +6 | −19 | Go to diff View file |
| M | src/common/Event/Event.class.php | +0 | −12 | Go to diff View file |
| A | src/common/User/BeforeLogin.php | +72 | −0 | Go to diff View file |
| M | src/common/User/LoginManager.class.php | +17 | −26 | Go to diff View file |
| M | tests/unit/common/User/User_LoginManagerTest.php | +130 | −69 | Go to diff View file |