stable

Clone or download

Read-only

Refactoring: delegate collection of errrors

Part of story #10678 define a query for title and description semantics No functional changes in validation of the expert query in both trackers and cross trackers. In a next commit, we will validate that if a comparison is made against @title or @description, then all trackers involved in the query are using the corresponding semantic. This means that we will need to pass the list of trackers id from the request to the collectErrors in the cross-trackers case. In order to produce small reviews, this commit only extract the collection of errors in a dedicated object. Change-Id: I5d5a034b6945b322dd60364dfe437ecca56b42d1

Modified Files

Name
M plugins/crosstracker/include/CrossTracker/REST/v1/CrossTrackerArtifactReportFactory.php +19 −2 Go to diff View file
M plugins/crosstracker/include/CrossTracker/REST/v1/CrossTrackerReportsResource.php +8 −6 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/InvalidComparisonCollectorVisitor.php +5 −5 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/ExpertQueryValidator.php +9 −16 Go to diff View file
A plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidSearchablesCollectionBuilder.php +46 −0 Go to diff View file
M plugins/tracker/include/Tracker/Report/Tracker_Report.class.php +10 −3 Go to diff View file
M plugins/tracker/include/autoload.php +3 −2 Go to diff View file