How to test: - In your web container, enable the feature flag: `tuleap config-set feature_flag_create_artifact 1` - Edit an artifact with an artifact link field with the modal (kanban, TTM or planning view) - When you enter some text in the search input of the lazybox for link selection in the artifact modal, the translated text of the button updates to include the text ("Create new artifact "<your text>"...") - When you click that button, the lazybox is still replaced by a creation inline form. The text input of that form is NOT auto-filled yet, this will be done later. - In the pullrequest overview page, edit the labels of a pullrequest. When you enter some text in the search input of the lazybox (in the modal), the translated text of the button updates to include the text. - No other functional change expected. Notes: I chose to use events instead of keeping the search callback in SearchInput. Using an event makes it easier to add more than one listener. Adding a separate listener for the "search-input" event in the Dropdown getter felt more clear than doing everything in a single callback. Similarly, the Dropdown now dispatches an event instead of using directly the callback from the options. It means LazyboxElement is responsible for dealing with the Options, while its components (Dropdown, SearchInput) do not need to know about them. They just send events up. part of story #28823 [modal] create artifact Change-Id: Idce56cf51bc9b6e4646356b4962deb414ed3507c

+247 −168

Author

Joris MASSON (jmasson) 2023-06-06 14:35

Committer

Joris MASSON (jmasson) 2023-06-08 09:39

Hash bdf8649ef679986ff7469557c51120b946c17a12

Parent 018ad414156bdc4cfa44fa2586056a978d5aee0d

Reference git #tuleap/stable/bdf8649ef679986ff7469557c51120b946c17a12