Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Merge GitlabMergeRequestReferenceBuilder and GitlabCommitReferenceBuilder

Download Browse

This is part of story #17182 reference tuleap artifacts in gitlab merge requests This patch aims to avoir DRY between GitlabMergeRequestReferenceBuilder and GitlabCommitReferenceBuilder No functional changes. How to test: - Have integrated GitLab repository - Commit with tuleap reference - Create/Edit/Close Merge request with tuleap reference Expected results: - xRef are created in artifacts (GitLab Commit, GitLab Merge Request) - You can click on the xRef and go to GitLab Change-Id: Id002bf40b4a34868f7da5fdceba2c1ffa9541dd7

+30 −117
Benjamin Bouillot (ben.bouillot) 2021-01-14 11:43
Benjamin Bouillot (ben.bouillot) 2021-01-15 14:44
c0b664d7e02804b3bd727d977c1100262ba2983e
0686b6ad5abbb0d719959917d551d91205f06f16
git #tuleap/stable/c0b664d7e02804b3bd727d977c1100262ba2983e

Modified Files

Side by side diff
Inline diff
Name
M plugins/gitlab/include/EventsHandlers/ReferenceAdministrationWarningsCollectorEventHandler.php +2 −2 Go to diff View file
R plugins/gitlab/include/Reference/GitlabCommit.php Go to diff View file
R plugins/gitlab/include/Reference/GitlabCrossReferenceEnhancer.php Go to diff View file
R plugins/gitlab/include/Reference/GitlabCommitFactory.php Go to diff View file
R plugins/gitlab/include/Reference/GitlabCommitReference.php Go to diff View file
D plugins/gitlab/include/Reference/GitlabCommitReferenceBuilder.php +0 −78 Go to diff View file
M plugins/gitlab/include/Reference/GitlabCrossReferenceOrganizer.php +5 −2 Go to diff View file
R plugins/gitlab/include/Reference/GitlabMergeRequestReferenceBuilder.php Go to diff View file
R plugins/gitlab/include/Reference/GitlabMergeRequestReference.php Go to diff View file
M plugins/gitlab/include/Repository/Webhook/PostMergeRequest/PostMergeRequestWebhookActionProcessor.php +1 −1 Go to diff View file
M plugins/gitlab/include/Repository/Webhook/PostPush/PostPushWebhookActionProcessor.php +1 −1 Go to diff View file
M plugins/gitlab/include/gitlabPlugin.php +14 −29 Go to diff View file
M plugins/gitlab/tests/unit/EventsHandlers/ReferenceAdministrationWarningsCollectorEventHandlerTest.php +2 −2 Go to diff View file
R plugins/gitlab/tests/unit/Reference/GitlabCrossReferenceEnhancerTest.php Go to diff View file
R plugins/gitlab/tests/unit/Reference/GitlabCommitFactoryTest.php Go to diff View file
M plugins/gitlab/tests/unit/Reference/GitlabCrossReferenceOrganizerTest.php +5 −2 Go to diff View file
R plugins/gitlab/tests/unit/Reference/GitlabCommitReferenceBuilderTest.php Go to diff View file