Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Remove download confirmation modal

Download Browse

Part of story #12404 download folder as zip Since the modal is always opened, it is likely that people will click it without reading when a problem does arise and there is actually a TULEAP_ERRORS.txt file. We will instead send an email (in another commit). How to test: - make tests_cypress should pass - when you download a zip folder with size inferior to the "warning limit", there won't be any modal. - Modals are still shown for "warning limit", "OSX warning" and "Max size limit" cases. Note: This solution brings back the Chromium warning: Resource interpreted as Document but transferred with MIME type application/x-zip But it can't be worked around. If we put the download URI as href in the link, people will be able to bypass the "size exceeded" modal with ctrl+click. Change-Id: I04758efcc8a6a218a8435234112ef18b10791b96

+36 −298
Joris MASSON (jmasson) 2020-05-25 12:38
Joris MASSON (jmasson) 2020-05-25 16:16
c17ec797feeca3d4963ef95de637187a784f8966
df72ebec1a0ff91b136433bf50d95bf3de2e1016
git #tuleap/stable/c17ec797feeca3d4963ef95de637187a784f8966

Modified Files

Side by side diff
Inline diff
Name
M plugins/document/scripts/document/components/Folder/DropDown/DownloadFolderAsZip/DownloadFolderAsZip.test.js +13 −17 Go to diff View file
M plugins/document/scripts/document/components/Folder/DropDown/DownloadFolderAsZip/DownloadFolderAsZip.vue +2 −5 Go to diff View file
M plugins/document/scripts/document/components/Folder/DropDown/DownloadFolderAsZip/ModalArchiveSizeWarning.vue +0 −11 Go to diff View file
D plugins/document/scripts/document/components/Folder/DropDown/DownloadFolderAsZip/ModalConfirmArchiveDownload.test.js +0 −63 Go to diff View file
D plugins/document/scripts/document/components/Folder/DropDown/DownloadFolderAsZip/ModalConfirmArchiveDownload.vue +0 −100 Go to diff View file
D plugins/document/scripts/document/components/Folder/DropDown/DownloadFolderAsZip/WarningAboutArchiveErrors.vue +0 −10 Go to diff View file
M plugins/document/scripts/document/components/Folder/FolderHeader.test.js +0 −20 Go to diff View file
M plugins/document/scripts/document/components/Folder/FolderHeader.vue +0 −18 Go to diff View file
M plugins/document/scripts/document/po/fr.po +0 −29 Go to diff View file
M plugins/document/tests/e2e/cypress/cypress/integration/document.spec.js +21 −25 Go to diff View file