stable
Clone or download
Read-only
When LDAP or OpenID Connect refuse a login attempt, they should be able to give an hint to end user that might get nuts trying to authenticate. Remove dead code in ldap afterLocalLogin. The code was no longer reachable because it was relying on ldap_id but the first condition already asserted it was empty. Part of request #16607 Allow ldap login when openidconnect client is used Change-Id: I92f320121034f9306e7c02f810352ecc35bd384e
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/dynamic_credentials/include/dynamic_credentialsPlugin.php | +1 | −1 | Go to diff View file |
| M | plugins/dynamic_credentials/site-content/fr_FR/LC_MESSAGES/tuleap-dynamic_credentials.po | +14 | −1 | Go to diff View file |
| M | plugins/ldap/include/ldapPlugin.php | +1 | −8 | Go to diff View file |
| M | plugins/ldap/site-content/fr_FR/LC_MESSAGES/tuleap-ldap.po | +1 | −1 | Go to diff View file |
| M | plugins/openidconnectclient/include/openidconnectclientPlugin.php | +1 | −1 | Go to diff View file |
| M | plugins/openidconnectclient/site-content/fr_FR/LC_MESSAGES/tuleap-openidconnectclient.po | +8 | −1 | Go to diff View file |
| M | src/common/User/AfterLocalLogin.php | +11 | −1 | Go to diff View file |
| M | src/common/User/InvalidPasswordWithUserException.class.php | +7 | −3 | Go to diff View file |
| M | src/common/User/LoginManager.class.php | +11 | −15 | Go to diff View file |
| M | src/common/User/UserAuthenticationSucceeded.php | +11 | −1 | Go to diff View file |
| M | tests/unit/common/User/User_LoginManagerTest.php | +5 | −3 | Go to diff View file |