stable
Clone or download
Read-only
part of request #29602 Migrate pullrequest file-diffs to TypeScript Now all the files - except the angular ones - have been migrated to typescript, it would be nice to have them sorted by purpose. For that, I propose the following structure: |- file-diff - contains the root directive + types |- code-collapse - code for collapsible sections |- diff-modes - unidiff + sbs components |- editors - editors stuff (scroll, modes, config, etc) |- file-lines - lines state + line helpers |- scroll-to-comment - scroll-to-comment feature files |- widgets - widgets creation and management |- placeholders If you have any suggestion on the following structure, I'll be happy to hear it :) No functional change expected Change-Id: Iaab5d693e1df7b0a2fb4df6e96a32ad8ad89b451
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/app.js | +1 | −1 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestComment.ts | +1 | −1 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/comments/new-comment-form/NewInlineCommentForm.ts | +1 | −1 | Go to diff View file |
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/code-mirror-common-sections-collapse.test.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/code-mirror-common-sections-collapse.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/code-collapse/collapsible-code-sections.test.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/code-collapse/collapsible-code-sections-test-fixture.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/code-collapse/collaspible-code-sections-builder.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-mode-state.ts | Go to diff View file | ||
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-diff-component.js | +17 | −17 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/unidiff-component.js | +8 | −8 | Go to diff View file |
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/comments-store.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-bidirectional-unicode-text.test.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-bidirectional-unicode-text.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/modes.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-code-mirrors-content-manager.test.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-code-mirrors-content-manager.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-scroll-synchronizer.test.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-scroll-synchronizer.ts | Go to diff View file | ||
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/file-diff-component.js | +3 | −3 | Go to diff View file |
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/file-line-helper.test.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/file-line-helper.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-line-grouper.test.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-line-grouper.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-line-mapper.test.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-line-mapper.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-lines-state.test.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-lines-state.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/file-diff-comment-scroller.test.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/file-diff-comment-scroller.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/file-diff-comment-widgets-map.test.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/file-diff-comment-widgets-map.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/types-codemirror-overriden.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/types.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/file-line-widget-placement-helper.test.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/file-line-widget-placement-helper.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/FileDiffPlaceholder.test.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/FileDiffPlaceholder.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-code-placeholder-creation-manager.test.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-code-placeholder-creation-manager.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-comment-placeholder-widget-finder.test.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-comment-placeholder-widget-finder.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-line-height-equalizer.test.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-line-height-equalizer.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-placeholder-positioner.test.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-placeholder-positioner.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-code-mirror-widget-creator.test.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-code-mirror-widget-creator.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-code-mirror-widgets-creation-manager.test.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-code-mirror-widgets-creation-manager.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-line-widgets-helper.test.ts | Go to diff View file | ||
| R | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-line-widgets-helper.ts | Go to diff View file | ||
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/files/files-controller.js | +1 | −1 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/tests/stubs/CreateInlineCommentWidgetStub.ts | +2 | −2 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/tests/stubs/CreateNewInlineCommentFormWidgetStub.ts | +2 | −2 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/tests/stubs/CreatePlaceholderWidgetStub.ts | +2 | −2 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/tests/stubs/FileDiffWidgetStub.ts | +2 | −2 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/tests/stubs/FileLineHandleStub.ts | +3 | −3 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/tests/stubs/FileLineStub.ts | +1 | −1 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/tests/stubs/FileLinesStateStub.ts | +4 | −8 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/tests/stubs/GroupOfLinesStub.ts | +2 | −6 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/tests/stubs/GroupSideBySideLinesStub.ts | +2 | −2 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/tests/stubs/MapSideBySideLinesStub.ts | +2 | −2 | Go to diff View file |