Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Enforce presence of "order" key in PATCH payload

Download Browse

Part of story #13626 Drag and drop cards How to test: Before this patch, passing a payload like: {"ids": [123], "direction": "after", "compared_to": 456 } was valid and even tested by the REST test. It should not have been valid. This patch will reject such payload and will accept this one: {"order":{ "ids": [123], "direction": "after", "compared_to": 456 } } Change-Id: I290addb94985993fe7dd19609a612880bc14bffc

+72 −6
Joris MASSON (jmasson) 2019-11-04 15:25
Joris MASSON (jmasson) 2019-11-05 12:14
c303f5c3146b1312bad3bbdf7852cc1c98a4f0b8
e41f395f7fe28648e989a0904a844aac61be7fe4
git #tuleap/stable/c303f5c3146b1312bad3bbdf7852cc1c98a4f0b8

Modified Files

Side by side diff
Inline diff
Name
M plugins/taskboard/include/REST/ResourcesInjector.php +1 −1 Go to diff View file
A plugins/taskboard/include/REST/v1/Cell/CellPatchRepresentation.php +47 −0 Go to diff View file
R plugins/taskboard/include/REST/v1/CellPatcher.php Go to diff View file
R plugins/taskboard/include/REST/v1/TaskboardCellResource.php Go to diff View file
R plugins/taskboard/phpunit/REST/v1/CellPatcherTest.php Go to diff View file
M plugins/taskboard/site-content/fr_FR/LC_MESSAGES/tuleap-taskboard.po +3 −0 Go to diff View file
M plugins/taskboard/tests/rest/TaskboardCellTest.php +21 −5 Go to diff View file