Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Corrupted file break the process

Download Browse

part of: story #12404 download folder as zip How to test: - Create a file (File or Embedded_File) - Delete its current_version in the plugin_docman_version table - In the UI, your file has a [CORRUPTED] badge - Download the archive --> No error --> The corrupted file is logged in codendi_syslog --> The archhive is well generated, does not contain the corrupted file Although this file does not appear in the archive, we should probably create a file in the archive with the same name and the following text: "this file is corrupted, it couldn't be append to the archive since it has no current version". May be done in another commit. Change-Id: I16ced99d3526d62b2dbacec5c0c015726a7386b8

+95 −15
Thomas Gorka (tgorka) 2020-05-15 10:52
Thomas Gorka (tgorka) 2020-05-15 11:53
c497fcb26cd6063a2f9e516b0865ad26beb1a6c7
c3e79277f4082cf4c3369551c72d604432c87a08
git #tuleap/stable/c497fcb26cd6063a2f9e516b0865ad26beb1a6c7

Modified Files

Side by side diff
Inline diff
Name
M plugins/document/include/DownloadFolderAsZip/ZipStreamFolderFilesVisitor.php +27 −6 Go to diff View file
M plugins/document/include/DownloadFolderAsZip/ZipStreamerLoggingHelper.php +11 −0 Go to diff View file
A plugins/document/include/Exceptions/DocmanFileCorruptedException.php +27 −0 Go to diff View file
M plugins/document/tests/unit/DownloadFolderAsZip/ZipStreamFolderFilesVisitorTest.php +30 −9 Go to diff View file