Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

request #23479 Openid and ldap user login generator must be the same

Download Browse

The login generator must be the same for openid and ldap when a new user is created from these ways. Moreover, openid login generator should generate a valid username. It's actually broken when it try to create a login from a name with accent : Badegùl as example. Change-Id: Ifaf77b71d3cdfc5cb52ac8eed048191e3685ba4e

+332 −251
Lorentz Romain (lorentzr) 2021-10-29 17:12
Lorentz Romain (lorentzr) 2021-11-05 16:26
c55f4069dc6ad198425e8e26cf05ca8be3b578b8
1aa2a78d3b18ff6b82b68f99098ec4563e40264b
git #tuleap/stable/c55f4069dc6ad198425e8e26cf05ca8be3b578b8

Modified Files

Side by side diff
Inline diff
Name
M plugins/ldap/include/LDAP_BackendSVN.class.php +3 −1 Go to diff View file
M plugins/ldap/include/LDAP_DirectorySynchronization.class.php +1 −1 Go to diff View file
M plugins/ldap/include/LDAP_UserGroupManager.class.php +3 −1 Go to diff View file
M plugins/ldap/include/LDAP_UserManager.class.php +9 −39 Go to diff View file
M plugins/ldap/include/ldapPlugin.php +2 −1 Go to diff View file
M plugins/ldap/tests/unit/UserManagerAuthenticateTest.php +6 −1 Go to diff View file
M plugins/ldap/tests/unit/UserManagerTest.php +0 −62 Go to diff View file
M plugins/openidconnectclient/include/OpenIDConnectClient/Login/Registration/UsernameGenerator.php +7 −36 Go to diff View file
M plugins/openidconnectclient/include/openidconnectclientPlugin.php +3 −2 Go to diff View file
M plugins/openidconnectclient/tests/unit/Login/Registration/UsernameGeneratorTest.php +66 −29 Go to diff View file
M plugins/tracker/composer.json +0 −1 Go to diff View file
M plugins/tracker/composer.lock +2 −76 Go to diff View file
R plugins/openidconnectclient/include/OpenIDConnectClient/Login/Registration/DataIncompatibleWithUsernameGenerationException.php Go to diff View file
A src/common/User/UserNameNormalizer.php +55 −0 Go to diff View file
M src/composer.json +1 −0 Go to diff View file
M src/composer.lock +75 −1 Go to diff View file
A tests/unit/common/User/UsernameNameNormalizerTest.php +99 −0 Go to diff View file