Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Artifact fatal error for wrong git commit reference

Download Browse

In an artifact, write a reference to a commit that does not exist (the wrong sha1 must have 40 chars). Submit and stay. ➡️ You should not get a fatal error. Issue introduced by git #tuleap/stable/5baac14c7e2cc13e558289228a536d728e34e3f6 Fix request #19276: Fatal error on artifact when referenced git commit does not exist Change-Id: I36b8519ad8f8656edbca3c1ba7b029f45dd4903e

+84 −6
Nicolas Terray (nterray) 2021-02-08 11:57
Nicolas Terray (nterray) 2021-02-08 11:57
c6cd23799dabe4589fac5f75d6a0a85a037bff6a
f1010815ceae0586c6dab6f49555c355ba5c8922
git #tuleap/stable/c6cd23799dabe4589fac5f75d6a0a85a037bff6a

Modified Files

Side by side diff
Inline diff
Name
M plugins/git/include/Git/Reference/CommitDetailsCrossReferenceInformationBuilder.php +6 −1 Go to diff View file
M plugins/git/include/Git/Reference/CommitDetailsRetriever.php +7 −3 Go to diff View file
M plugins/git/include/GitPHP/git/Commit.php +1 −1 Go to diff View file
M plugins/git/include/REST/v1/GitCommitRepresentation.php +1 −1 Go to diff View file
M plugins/git/tests/unit/Git/Reference/CommitDetailsCrossReferenceInformationBuilderTest.php +40 −0 Go to diff View file
M plugins/git/tests/unit/Git/Reference/CommitDetailsRetrieverTest.php +29 −0 Go to diff View file