Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Refactoring move Tracker_Artifact_Creator into a dedicated mespace

Download Browse

part of story #16125 [release management] create a new Aggregator Release This patch is not mandatory to make Safe work, but as we are doing a lot of changes in artifact creation I took the opportunity to be here to : - have a builder, so next injections will be less painfull - extract it in a dedicated namespace - add the typehinting required by psalm - remove the patter of returning Tracker_Artifact|false to have ?Tracker_Artifact instead Change-Id: Ie83c3b11a8fa6ee9995a8a94af7bb23dc8e00aa0

+51 −91
Marie Ange Garnier (marieange) 2020-10-09 15:38
Marie Ange Garnier (marieange) 2020-10-13 15:32
c7d670e06d25ec9a3b7311a76d70bb71641b10f1
f0324251402583524853ede5e5e943c26d435ae8
git #tuleap/stable/c7d670e06d25ec9a3b7311a76d70bb71641b10f1

Modified Files

Side by side diff
Inline diff
Name
M plugins/multi_project_backlog/include/Aggregator/Milestone/Mirroring/Asynchronous/CreateMirrorsTask.php +4 −16 Go to diff View file
M plugins/multi_project_backlog/include/Aggregator/Milestone/Mirroring/MirrorMilestonesCreator.php +4 −3 Go to diff View file
M plugins/multi_project_backlog/tests/unit/Aggregator/Milestone/Mirroring/MirrorMilestonesCreatorTest.php +6 −5 Go to diff View file
R plugins/tracker/include/Tracker/Artifact/Tracker_ArtifactCreator.class.php Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Tracker_ArtifactFactory.class.php +12 −17 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/XMLImport.class.php +4 −3 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/XMLImportBuilder.class.php +5 −15 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/dao/Tracker_ArtifactDao.class.php +1 −1 Go to diff View file
M plugins/tracker/include/Tracker/Migration/MigrationManager.php +4 −10 Go to diff View file
M plugins/tracker/include/Tracker/Tracker.class.php +4 −15 Go to diff View file
M plugins/tracker/tests/unit/Artifact/Tracker_Artifact_XMLImportTest.php +4 −3 Go to diff View file
R plugins/tracker/tests/unit/Tracker/Artifact/Tracker_ArtifactCreatorTest.php Go to diff View file
M plugins/tracker/tests/unit/Tracker/Artifact/XmlImportTest.php +3 −3 Go to diff View file