Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: Use events to attach uploaded image to file field

Download Browse

How to test: No functional change for image drag/drop in the artifact modal: When the image has finished uploading, it is still added to one File field. part of request #31111: Remove global states in the artifact modal Change-Id: I6931eda821882092633bfc7ec776e1e734e95d63

+149 −137
Joris MASSON (jmasson) 2023-03-03 10:58
Joris MASSON (jmasson) 2023-03-07 15:30
c9edb11e6f13f231fad7546c0fb624369f29e615
21447049a866714841326a6b9ca8e8d60ef59dfd
git #tuleap/stable/c9edb11e6f13f231fad7546c0fb624369f29e615

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/comments/ModalCommentsSection.test.ts +0 −12 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/comments/ModalCommentsSection.ts +0 −5 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/file-field/file-field-validator.ts +6 −10 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/common/RichTextEditor.test.ts +4 −16 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/common/RichTextEditor.ts +2 −8 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/common/text-and-format.test.ts +0 −24 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/common/text-and-format.ts +1 −6 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/domain/DomainEvent.ts +2 −0 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/domain/common/FileUploadQuotaController.test.ts +0 −1 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/domain/common/FormattedTextController.test.ts +20 −3 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/domain/common/FormattedTextController.ts +4 −3 Go to diff View file
A plugins/tracker/scripts/lib/artifact-modal/src/domain/fields/file-field/DidUploadImage.ts +32 −0 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/domain/fields/file-field/FileFieldController.test.ts +37 −3 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/domain/fields/file-field/FileFieldController.ts +12 −1 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/domain/fields/file-field/FileFieldValueModel.ts +2 −0 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/domain/fields/file-field/FileUploadSetup.ts +0 −1 Go to diff View file
A plugins/tracker/scripts/lib/artifact-modal/src/domain/fields/file-field/UploadedImage.ts +27 −0 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/tuleap-artifact-modal-controller.js +0 −10 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/tuleap-artifact-modal-controller.test.js +0 −32 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/tuleap-artifact-modal.tpl.html +0 −2 Go to diff View file