stable

Clone or download

Read-only

Refactoring: split IndexController into smaller objects

Part of story #10062: Users & groups management overhaul In order to go toward SRP, we introduce dedicated presenter builders: - for the current ugroup - for its members - for its binding For each of those builders, a main presenter has been extracted as object instead of associative array. However we stop at this level since building small presenters deep in the hierarchy does not bring any values and may produce unreadable code. Permissions presenter building does not need to be moved since they will be deleted in another story. Change-Id: Icaa1a800c88930343e119411fbd86ff22427eeee

Modified Files

Name
M src/common/autoload.php +8 −2 Go to diff View file
A src/common/project/Admin/ProjectUGroup/BindingPresenter.php +43 −0 Go to diff View file
A src/common/project/Admin/ProjectUGroup/BindingPresenterBuilder.php +190 −0 Go to diff View file
M src/common/project/Admin/ProjectUGroup/IndexController.php +8 −326 Go to diff View file
A src/common/project/Admin/ProjectUGroup/MembersPresenter.php +39 −0 Go to diff View file
A src/common/project/Admin/ProjectUGroup/MembersPresenterBuilder.php +78 −0 Go to diff View file
A src/common/project/Admin/ProjectUGroup/ProjectUGroupPresenter.php +59 −0 Go to diff View file
A src/common/project/Admin/ProjectUGroup/ProjectUGroupPresenterBuilder.php +169 −0 Go to diff View file
M src/common/project/Admin/ProjectUGroup/UGroupRouter.class.php +0 −2 Go to diff View file
M src/www/project/admin/editugroup.php +15 −7 Go to diff View file