Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactoring: interface VerifyIsProgramIncrementTracker

Download Browse

part of story #21368 create mirrored iteration No functional change expected Code was building a full Tracker object when in fact all we needed to check was that a tracker is (or is not) a program increment tracker. Some of the checks did not properly catch exceptions too, so they would bubble and result in errors. Extracting this will simplify code when we build a SourceTrackerCollection with a named constructor pattern Change-Id: I5c5e4423a07b422820f902d44e2f213892cb1ef6

+243 −387
Joris MASSON (jmasson) 2021-06-02 16:54
Joris MASSON (jmasson) 2021-06-02 18:20
cc82fa0e0626be76e4969c1c384d285ff7a8c4d4
eb555b0a985582811e2dec506fdbe0703c0bb5fe
git #tuleap/stable/cc82fa0e0626be76e4969c1c384d285ff7a8c4d4

Modified Files

Side by side diff
Inline diff
Name
M plugins/program_management/include/Adapter/Program/Backlog/ProgramIncrement/ProgramIncrementsDAO.php +0 −8 Go to diff View file
M plugins/program_management/include/Adapter/Program/Feature/Content/ProgramIncrementChecker.php +7 −13 Go to diff View file
D plugins/program_management/include/Adapter/Program/Feature/TrackerShouldPlanFeatureChecker.php +0 −56 Go to diff View file
M plugins/program_management/include/Adapter/Program/Plan/PlanDao.php +10 −1 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/AsynchronousCreation/ArtifactCreatedHandler.php +10 −35 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/CreationCheck/ProgramIncrementCreatorChecker.php +9 −26 Go to diff View file
A plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/VerifyIsProgramIncrementTracker.php +28 −0 Go to diff View file
M plugins/program_management/include/REST/v1/ProgramIncrementResource.php +4 −3 Go to diff View file
M plugins/program_management/include/program_managementPlugin.php +9 −12 Go to diff View file
D plugins/program_management/tests/unit/Adapter/Program/Feature/CanProgramIncrementBeChangedCheckerTest.php +0 −96 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Feature/Content/ProgramIncrementCheckerTest.php +40 −52 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/AsynchronousCreation/ArtifactCreatedHandlerTest.php +52 −45 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/CreationCheck/ProgramIncrementCreatorCheckerTest.php +24 −40 Go to diff View file
A plugins/program_management/tests/unit/Stub/VerifyIsProgramIncrementTrackerStub.php +50 −0 Go to diff View file