Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactoring: build MappedStatusValue with a static method

Download Browse

part of request #22231 Decrease adapter responsibility No functional change expected when creating mirror program increments. You can use cypress tests for non-regression. Change-Id: Ie59fdd13db75301d06f70d86dfef6b4f4b779c06

+587 −129
Joris MASSON (jmasson) 2021-08-13 17:30
Joris MASSON (jmasson) 2021-08-17 11:36
d19cd05611342958b712861b473f8fb329425cc2
588b2d943a8222a116d6d8ef714e19251323632e
git #tuleap/stable/d19cd05611342958b712861b473f8fb329425cc2

Modified Files

Side by side diff
Inline diff
Name
M plugins/program_management/include/Adapter/Program/Backlog/AsynchronousCreation/StatusValueMapper.php +25 −31 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/AsynchronousCreation/TaskBuilder.php +1 −5 Go to diff View file
A plugins/program_management/include/Adapter/Program/Backlog/ProgramIncrement/Source/Changeset/Values/BindValueIdentifierProxy.php +48 −0 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/AsynchronousCreation/MapStatusByValue.php +5 −7 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/AsynchronousCreation/ProgramIncrementsCreator.php +7 −2 Go to diff View file
A plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/Source/Changeset/Values/BindValueIdentifier.php +35 −0 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/Source/Changeset/Values/MappedStatusValue.php +28 −7 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/AsynchronousCreation/StatusValueMapperTest.php +187 −56 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/ArtifactCreatorAdapterTest.php +9 −4 Go to diff View file
A plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/Source/Changeset/Values/BindValueIdentifierProxyTest.php +57 −0 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/AsynchronousCreation/ProgramIncrementsCreatorTest.php +3 −15 Go to diff View file
A plugins/program_management/tests/unit/Domain/Program/Backlog/ProgramIncrement/Source/Changeset/Values/MappedStatusValueTest.php +73 −0 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/ProgramIncrement/Source/Fields/ProgramIncrementFieldsDataTest.php +9 −2 Go to diff View file
A plugins/program_management/tests/unit/Stub/BindValueIdentifierStub.php +45 −0 Go to diff View file
A plugins/program_management/tests/unit/Stub/MapStatusByValueStub.php +55 −0 Go to diff View file