Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Tracker_FormElement_Field_List unit tests can be executed with PHP 8

Download Browse

Thanks to the saner string to number comparison introduced in PHP 8.0 [0] an incorrect validation has been spotted in this class. The test should now pass with PHP 8.0: make tests-unit-php PHP_VERSION=80 FILES=plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_List.php Part of request #17931: Unit tests should pass with PHP 8.0 https://www.php.net/releases/8.0/en.php#saner-string-to-number-comparisons Change-Id: Ife4dfe014816aeaa5ebec657c91c39a40b8df7e3

+19 −11
Thomas Gerbet (tgerbet) 2020-12-22 11:35
Thomas Gerbet (tgerbet) 2020-12-22 11:41
d2b8c5aa847bfd1993bc9b48ba81ccd8e4f933e6
64b3f6771273294d984944e2169ba3c9a5672354
git #tuleap/stable/d2b8c5aa847bfd1993bc9b48ba81ccd8e4f933e6

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/include/Tracker/FormElement/Field/ListFields/FieldValueMatcher.php +1 −1 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_List.php +4 −8 Go to diff View file
M plugins/tracker/tests/unit/Tracker/FormElement/Tracker_FormElement_Field_ListTest.php +14 −2 Go to diff View file