stable

Clone or download

Read-only

refactor: extract dedicated class for closing keyword

part of story #26802 have smart commit with Tuleap Git No functional change expected in GitLab artifact closure: If you push a commit with a "close" keyword and a reference to a Tuleap artifact (for example TULEAP-6555), the artifact is closed with a comment. Notes: We will need to have a way to parse the closing keywords for Git commits. This change introduces a dedicated class for this purpose. In a next contribution, it will be moved to Git plugin. Change-Id: I6d7f902bdc15b8fcbd2a3880e9711b34076e16e4

Modified Files

Name
A plugins/gitlab/include/Repository/Webhook/ClosingKeyword.php +140 −0 Go to diff View file
M plugins/gitlab/include/Repository/Webhook/PostPush/PostPushArtifactComment.php +8 −15 Go to diff View file
M plugins/gitlab/include/Repository/Webhook/PostPush/PostPushWebhookCloseArtifactHandler.php +1 −1 Go to diff View file
M plugins/gitlab/include/Repository/Webhook/WebhookTuleapReference.php +4 −17 Go to diff View file
M plugins/gitlab/include/Repository/Webhook/WebhookTuleapReferencesParser.php +5 −64 Go to diff View file
M plugins/gitlab/tests/unit/Repository/Webhook/Bot/BotCommentReferencePresenterBuilderTest.php +2 −2 Go to diff View file
A plugins/gitlab/tests/unit/Repository/Webhook/ClosingKeywordTest.php +109 −0 Go to diff View file
M plugins/gitlab/tests/unit/Repository/Webhook/PostMergeRequest/PostMergeRequestBotCommenterTest.php +6 −4 Go to diff View file
M plugins/gitlab/tests/unit/Repository/Webhook/PostMergeRequest/PostMergeRequestWebhookActionProcessorTest.php +2 −2 Go to diff View file
M plugins/gitlab/tests/unit/Repository/Webhook/PostMergeRequest/PreviouslySavedReferencesRetrieverTest.php +2 −2 Go to diff View file
M plugins/gitlab/tests/unit/Repository/Webhook/PostPush/PostPushArtifactCommentTest.php +46 −55 Go to diff View file
M plugins/gitlab/tests/unit/Repository/Webhook/PostPush/PostPushCommitBotCommenterTest.php +4 −4 Go to diff View file
M plugins/gitlab/tests/unit/Repository/Webhook/PostPush/PostPushWebhookCloseArtifactHandlerTest.php +3 −2 Go to diff View file
M plugins/gitlab/tests/unit/Repository/Webhook/WebhookTuleapReferenceCollectionTest.php +5 −5 Go to diff View file
M plugins/gitlab/tests/unit/Repository/Webhook/WebhookTuleapReferenceTest.php +18 −2 Go to diff View file
M plugins/gitlab/tests/unit/Repository/Webhook/WebhookTuleapReferencesParserTest.php +42 −44 Go to diff View file