Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactoring: Build EndPeriodValue with a static method

Download Browse

part of request #22231 Decrease adapter responsibility No functional change expected when creating mirror program increments. You can use cypress tests for non-regression. Change-Id: I28f1c6adeabf0b2ca4ca8dc20496156989d38df2

+182 −258
Joris MASSON (jmasson) 2021-08-13 15:17
Joris MASSON (jmasson) 2021-08-16 14:21
d5e38d7a649ee4b362772fcf8da8e984b6de59e5
089a6c5a73a7ab43f4279d6f9b3a940d871cd353
git #tuleap/stable/d5e38d7a649ee4b362772fcf8da8e984b6de59e5

Modified Files

Side by side diff
Inline diff
Name
M plugins/program_management/include/Adapter/Program/Backlog/AsynchronousCreation/TaskBuilder.php +1 −2 Go to diff View file
D plugins/program_management/include/Adapter/Program/Backlog/ProgramIncrement/EndPeriodValueAdapter.php +0 −47 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/ProgramIncrement/Source/Changeset/Values/ArtifactFieldValuesRetriever.php +17 −1 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/ProgramIncrement/SourceChangesetValuesCollectionAdapter.php +16 −14 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/Source/Changeset/Values/EndPeriodValue.php +18 −5 Go to diff View file
R plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/Source/Changeset/Values/BuildEndPeriodValue.php Go to diff View file
D plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/EndPeriodValueAdapterTest.php +0 −173 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/Source/Changeset/Values/ArtifactFieldValuesRetrieverTest.php +29 −1 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/SourceChangesetValuesCollectionAdapterTest.php +6 −14 Go to diff View file
M plugins/program_management/tests/unit/Builder/SourceChangesetValuesCollectionBuilder.php +6 −1 Go to diff View file
A plugins/program_management/tests/unit/Domain/Program/Backlog/ProgramIncrement/Source/Changeset/Values/EndPeriodValueTest.php +42 −0 Go to diff View file
A plugins/program_management/tests/unit/Stub/RetrieveEndPeriodValueStub.php +47 −0 Go to diff View file