Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

request #20109 Pullrequest reviewers REST endpoint can throw an unhandled exception

Download Browse

Given a private project, with a Git repository and a pullrequest. If I add a project member as a reviewer of the pullrequest, and then remove him/her as a project member, then the API endpoint pull_requests/:id/reviewers returns an error 500. Change-Id: Ib6fac8cf506e584785081cb26d9cd3d4913deae2

+94 −2
Yannis ROSSETTO (rossettoy) 2021-03-19 16:07
Yannis ROSSETTO (rossettoy) 2021-03-19 16:07
d6e5222397a97f0d5a4dcea2e4ac408f0fe8581f
df671243850b4da7dd82342061e0bc21409a5efb
git #tuleap/stable/d6e5222397a97f0d5a4dcea2e4ac408f0fe8581f

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/include/PullRequest/Reviewer/ReviewerRetriever.php +2 −1 Go to diff View file
M plugins/pullrequest/include/PullRequest/Reviewer/ReviewerUpdater.php +2 −1 Go to diff View file
M plugins/pullrequest/tests/unit/Reviewer/ReviewerRetrieverTest.php +42 −0 Go to diff View file
M plugins/pullrequest/tests/unit/Reviewer/ReviewerUpdaterTest.php +48 −0 Go to diff View file