Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Group together closing and closing post-action of a pull-request

Download Browse

This change group together the fact of closing a PR and the fact of adding this information into the timeline the PR. Until now, it was the developer responsability to remember that it needs to do such action after closing a PR. Since we are going to add more things to do after the closing of PR we need to make sure those post actions will not be forgotten and code is not duplicated. This is a technical change, no functional change is expected. Part of story #14190: get email notifications on pull requests - first stage Change-Id: I9edc22b43389c1e8c4ed7db45b7997b51f0b6c31

+243 −100
Thomas Gerbet (tgerbet) 2019-11-27 10:47
Thomas Gerbet (tgerbet) 2019-11-27 12:13
d83590a4e632ac62694a409160e4b6901e8a6bef
5e202a528c334a5abbe77470abc2fcae240a104e
git #tuleap/stable/d83590a4e632ac62694a409160e4b6901e8a6bef

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/include/PullRequest/Factory.php +1 −11 Go to diff View file
M plugins/pullrequest/include/PullRequest/PullRequestCloser.php +52 −19 Go to diff View file
M plugins/pullrequest/include/PullRequest/REST/v1/PullRequestsResource.php +5 −7 Go to diff View file
M plugins/pullrequest/include/PullRequest/REST/v1/StatusPatcher.php +1 −10 Go to diff View file
M plugins/pullrequest/include/pullrequestPlugin.php +16 −13 Go to diff View file
A plugins/pullrequest/phpunit/PullRequestCloserTest.php +168 −0 Go to diff View file
M plugins/pullrequest/phpunit/REST/v1/StatusPatcherTest.php +0 −40 Go to diff View file