Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Refacto: simplify date validation

Download Browse

This is a part of story #8859 TQL search on date & numeric fields By considering that we always get a collection of values to validate for a date field, we can simplify the current implementation by having only one object to extract values and one object to validate values. date = now() => collection of 1 value: [now()] date between(now() - 1y, now()) => collection of 2 values: [now() - 1y, now()] On the bonus side, we don't have anymore a "ghost" method visitBetweenXxx that was empty on a visitor and not on the other. Change-Id: I77f20654a21e25103804d0f2c4f6f715861589e7

+58 −174
Nicolas Terray (nterray) 2017-01-26 21:25
Nicolas Terray (nterray) 2017-01-26 21:31
d8714a188475eecc99710ddf689616ded3c938c1
e6d7329b7f253df893f0c939069422d7a6e48f22
git #tuleap/stable/d8714a188475eecc99710ddf689616ded3c938c1

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/BetweenComparisonVisitor.php +10 −12 Go to diff View file
R plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/Date/BetweenDateValuesExtractor.php Go to diff View file
D plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/Date/DateFieldBetweenValueChecker.php +0 −52 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/Date/DateFieldChecker.php +9 −7 Go to diff View file
D plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/Date/DateValueExtractor.php +0 −62 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/EqualComparisonVisitor.php +5 −5 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/GreaterThanComparisonVisitor.php +5 −5 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/GreaterThanOrEqualComparisonVisitor.php +5 −5 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/LesserThanComparisonVisitor.php +5 −5 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/LesserThanOrEqualComparisonVisitor.php +5 −5 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/NotEqualComparisonVisitor.php +5 −5 Go to diff View file
M plugins/tracker/include/autoload.php +3 −5 Go to diff View file
M plugins/tracker/tests/Tracker/Report/Query/Advanced/InvalidFields/DateFieldCheckerTest.php +3 −3 Go to diff View file
M plugins/tracker/tests/Tracker/Report/Query/Advanced/InvalidFields/DateTimeFieldCheckerTest.php +3 −3 Go to diff View file