Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Refactoring: Fix mutations and actions

Download Browse

Part of story #11347 have a UI to access Move artifact No functional changes expected. - Add jasmine 3.2's async matchers for rest querier tests. It reminds of the jasmine-promise-matchers plugin we added for AngularJS and helps a little with asserting native promises. - Reworked the mutations. I'm sick of getter/setter in Vuex mutations. No more! Now we have meaningful operations. States that are changed together should be in the same mutation. Booleans are "reset" when switched to false. As a result, there is a lot fewer mutations. - Actions do the redirection. Since "window" can't be spied upon by jasmine, we need a little helper module that we can then rewire. Business as usual. As a result, there is no more "should_redirect" flag. Change-Id: Ib6607684b6e6e456d7377c1d3eb1174b083d3377

+211 −208
Joris MASSON (jmasson) 2018-08-13 16:52
Joris MASSON (jmasson) 2018-08-16 13:17
d945d7b465eb3d3a354e9705cfbd664272d93cd8
972e62d439b9a427ba565afabc2c5ebb6a11d4e5
git #tuleap/stable/d945d7b465eb3d3a354e9705cfbd664272d93cd8

Modified Files

Side by side diff
Inline diff
Name
M .eslintrc +2 −0 Go to diff View file
M package-lock.json +3 −3 Go to diff View file
M package.json +1 −1 Go to diff View file
M plugins/tracker/www/scripts/artifact-action-buttons/src/api/rest-querier.spec.js +28 −30 Go to diff View file
M plugins/tracker/www/scripts/artifact-action-buttons/src/app.spec.js +1 −1 Go to diff View file
M plugins/tracker/www/scripts/artifact-action-buttons/src/components/MoveModal.vue +6 −26 Go to diff View file
M plugins/tracker/www/scripts/artifact-action-buttons/src/components/TrackerSelector.vue +1 −3 Go to diff View file
M plugins/tracker/www/scripts/artifact-action-buttons/src/store/actions.js +42 −48 Go to diff View file
M plugins/tracker/www/scripts/artifact-action-buttons/src/store/actions.spec.js +68 −56 Go to diff View file
M plugins/tracker/www/scripts/artifact-action-buttons/src/store/mutations.js +36 −39 Go to diff View file
M plugins/tracker/www/scripts/artifact-action-buttons/src/store/state.js +1 −1 Go to diff View file
A plugins/tracker/www/scripts/artifact-action-buttons/src/window-helper.js +22 −0 Go to diff View file