Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

GET /pull_requests/{id}/reviewers only returns users able to access the PR

Download Browse

The REST endpoint to udpate the reviewers on a PR rejects users that cannot access it. Having those ones in the retrieved list will cause discrepancies when updating it. Also this might be confusing for the users since they might expect a review from one reviewer that can not access the code. The situation where a user is in the list of reviewers but cannot access it can only happen when permissions are changed. Part of story #14190: get email notifications on pull requests - first stage Change-Id: Ibce76dde52880667a71faf49f094f483130f9c79

+51 −9
Thomas Gerbet (tgerbet) 2019-11-22 12:51
Thomas Gerbet (tgerbet) 2019-11-22 12:51
d992b71d42627ffaa3a317d3b87b489a571242a5
bb306b56c90a4ae3ca4affac7512a5dd6302eef9
git #tuleap/stable/d992b71d42627ffaa3a317d3b87b489a571242a5

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/include/PullRequest/REST/v1/PullRequestsResource.php +1 −1 Go to diff View file
M plugins/pullrequest/include/PullRequest/Reviewer/ReviewerRetriever.php +21 −5 Go to diff View file
M plugins/pullrequest/phpunit/Reviewer/ReviewerRetrieverTest.php +29 −3 Go to diff View file