Part of story #36833 search on semantics and always there fields even if not defined How to test: - @status IN / NOT IN(OPEN()) should be flagged as invalid instead of causing a PHP Fatal error. - No other functional change. CI should be happy. Why ? IN(OPEN()) was never supported, the query builder does not handle it. This is part of the refactoring of the structure of the query validation to transition away from checks being grouped by comparison type (equals, lesser than, etc). We want to group checks by semantic / field type instead, as it is easier to understand. Most of the time, we work "field by field", so it makes more sense to have all the business rules for a given field in as few files as possible, instead of having all the business rules for "equals" comparisons being grouped together. Furthermore, usage of inheritance makes it hard to keep a mental model of the validation rules for a given field. Change-Id: Ieb98797931d0e8493a190a66dd183e495e73568e

+120 −3

Author

Joris MASSON (jmasson) 2024-03-22 16:34

Committer

Joris MASSON (jmasson) 2024-03-22 17:21

Hash d9dcced6d47a4399332476adf089680afa54e38e

Parent a56b6aba6f5deb93228033d1335ee5385de630a0

Reference git #tuleap/stable/d9dcced6d47a4399332476adf089680afa54e38e